Skip to content
OverviewSolutions
4
Comments
15

maicond

@maicondguerianFlorianópolis -sc230 points

Estudante de Sistema des Informação na Estácio | Information Systems student at Estácio College

I’m currently learning...

react.js, next-js

Latest solutions

Latest comments

  • maicond•230
    @maicondguerianPosted over 1 year ago

    O layout ficou identico Daniel! Parabéns! Só faltou uma verificação pra ver se algum rating esta selecionado antes de ir para a página de agradecimentos.Uma bloco de if else simples resolve isso aí. Abraço.

    1
  • maicond•230
    @maicondguerianPosted over 1 year ago

    Hey, how's it going? Pretty nice work!

    You almost got it right, but forgot some things:

    .container {
    display: flex;
    flex-direction: column;
    align-items: center; 
    height: 100vh; /* to set your view height at 100vh of the screen */
    justify-content: center; /* to set your content horizontally in the middle of the screen */
} 
.qrcode {
    background: hsl(0, 0%, 100%);
    /* margin-top: 40px; // remove this line */
    /* padding-top: 20px; // remove this line */
    /* padding-left: 20px; // remove this line */
    /* padding-right: 20px; // remove this line */
    /* padding-bottom: 40px; // remove this line */
    padding: 20px 20px 40px; /* you can avoid the verbosity by declaring all sides padding by passing the properties in PADDING: the first argument is about top, second: right, third: bottom, fourth: left */
    border-radius: 20px;
    width: 250px;
}
    Marked as helpful
    0
  • maicond•230
    @maicondguerianPosted over 1 year ago

    "Hey Faizal, before I provide my feedback, are you Brazilian? By the way, you did a pretty good job on this project with Tailwind and React. The final outcome was quite close to the challenge's requirements. However, from my understanding, React is about creating small, reusable components by breaking down the responsibilities into smaller, more organized components., that when togheter, make your application.

    To make it even better, here are a few things you can improve:

    • Create a context to pass props through it. Prop drilling isn't always recommended, and using context will certainly make your code easier to maintain and understand.

    • Create more components for various parts of your application, such as Header, Cart, ProductGallery, Description, or BuytSide.

    • I noticed you used an alert to display a success message when a product is added to the cart. There's a library called React-toastify designed for this purpose; it would be cooler to use it instead of an alert.

    • When you add a product to the cart, the counter should reset to zero, creating a more immersive experience.

    • Currently, you are replacing the quantity of the product with the new quantity, rather than adding the old quantity to the new one.

    • The last thing is that you are reusing the modal component for mobile resolution. While this is a nice solution, you can make it a modal with a display:block instead and remove the overlay to make it blend in with the rest of the content. But once again, I liked your solution!"

    Marked as helpful
    0
  • maicond•230
    @maicondguerianPosted almost 2 years ago

    Redondidnho hein? notou diferença na utulização do vite na criação e instalações de depencias no projeto? rs

    0
  • maicond•230
    @maicondguerianPosted almost 2 years ago

    Opa! bacana, seu projeto faltou apenas a parte da r4sponsividade no projeto para dispositivos motives e resoluções abaixo de desktop no mais o resultado ficou bom parabéns!

    Marked as helpful
    1
  • maicond•230
    @maicondguerianPosted almost 2 years ago

    Eai Henrique beleza? show seu projetinho em ts hein? proxima coisa que quero aprender js tipado, tu usou cra para fazer esse projetinho né? já conhece o vite? next-js? Usa coisa que você deveria ter feito é deixar a o imagem mobile e o componente/container do form com width 100% ficaria mais agradavel visualmente, de resto ta show parabens aí!

    Marked as helpful
    0
View more comments