Skip to content
OverviewSolutions
3
Comments
3
Luis Gonzalez
@luisgonzalez2001

All comments

  • Luis Gonzalez•70
    @luisgonzalez2001Posted about 2 months ago

    Everything looks great, just don't use id in this case to style the image, I would also put an "alt" text just for good practice

    1
  • Luis Gonzalez•70
    @luisgonzalez2001Posted about 2 months ago

    Everything looks fine, only I would remove the shadow class and put it in the main class like; box-shadow: 8px 8px 0px hsl(0, 0%, 7%);

    Marked as helpful
    0
  • Ken•160
    @ubcyukinySubmitted 2 months ago
    What are you most proud of, and what would you do differently next time?

    Most proud of the completion of the project.

    What challenges did you encounter, and how did you overcome them?

    1. Margins and paddings were confusing at first, but by using Google DevTools, hovering on the computed panel, makes it easier to understand and debug

    2. Figuring how to center the QR Code card component inside the body. Tried multiple solution from stack overflow, for eg. margin: auto, which only centers horizontally and other solutions like

    body {
   display: flex;
   justify-content: center;
   align-items: center; 
}

    Stumbled on adding height:100vh, which seems to fix the issue.

    What specific areas of your project would you like help with?

    I need to work on my understanding of the display property and viewport unit. Would also appreciate some feedback on my coding style!

    QR code component using html and css

    1
    Luis Gonzalez•70
    @luisgonzalez2001Posted 2 months ago

    Podrías reducir la cantidad de código que utilizaste para estilar, por ejemplo; el font-family podrías ponerlo en el body y así tenerlo ya heredado en todo el proyecto, al igual con las propiedades margin y padding que reciben 4 parámetros en una linea (arriba, derecha, abajo e izquierda)

    Marked as helpful
    1