Hello!
I am fairly new to programming so if someone could refractor/see holes in my JS code it would be greatly appreciated. I am trying to keep functions short but it can be hard sometimes and it feels that i might be losing out on some array/string methods that i could be using.
At least i managed to get the code to run and the calculator to work.
What challenges did you encounter, and how did you overcome them?I just couldn't make the JavaScript code reuseable nor standard, the code has a very low performance.
What specific areas of your project would you like help with?I would love to get help in writing more standard JavaScript code. My javascript is very bad.
The calculator is not working; the button remains active after switching. There’s no error handling. For the button functionality, you just need to track the last clicked button in JavaScript. For example, if button one is clicked, set button.style.backgroundColor = 'green', and reset the background color of all other buttons. For error handling, track the value of your input fields. If the value is 0, display the <p> element containing the error message by setting display: block.
Care about your file on assets , assets is here to contain extern source , like image font sound ... not code. But you did realy great job keep going mate
We’re on the same page about already creating the div in HTML instead of generating it in the DOM with JavaScript. Just keep in mind that you can add styles directly in JavaScript, like setting yourElement.style.display = "none"; or "block". This can make it easier for others to read and understand your code. Honestly, you did a great job!
Me orgulho em ter conseguido fazer a responsividade do projeto, sem ver alguma video aula de curso!
What challenges did you encounter, and how did you overcome them?desafio enorme com media queries
What specific areas of your project would you like help with?media queries
There is too much padding and margin so your components are way too big , but for the rest you did preety good job!,
There’s an issue with the responsiveness; the min-width is set too high, so even on a desktop screen, it displays in mobile view. You should adjust it. I give you this website he is working well : https://media-queries.aliasdmc.fr/media-queries-live.php
The responsive is not good at all , same about color and some design details (button , margins ...), the fact you use a div with class collumn just for an img doesnt have sense for me. Your code was easy to read that a good point , keep going
Your HTML looks good, and your CSS coding is well done. However, there are some margins and paddings missing in your project. For example, your <main> section could use some padding, and each <li> should have top and bottom margins. Right now, everything is very close together, so adding more space could make the page look much better. Overall, you did a great job on this project!
I think there is a better choice to put button tag on html instead of class "button" and you could find better selector on css to make you not repeat code. but the result is pretty good , great job.
the way you setup all properties on your css file is good keep going
