@rahimi-1997Submitted about 1 year ago
Hi there 👋, I’m Raha and this is my solution for this challenge. 🚀
Any suggestions on how I can improve and reduce unnecessary code are welcome!
Thank you. 😊✌️
Lima Neto
@limanetoAll comments
- @limanetoPosted about 1 year ago
congrats the code looks good, you did not overuse display flex, thats good, a improvenment you could do is remove unecessary class and tags, for example the you could put everything that is inside the div card inside the main tag, also do the same for div wrapper and div card_body, by the way that class is not being used to assign style.
1 - @NeshomagoSubmitted over 2 years ago
Is it a better way to improve the html tags layout? and how to make the css more responsive?
@limanetoPosted over 2 years agohey, good work there! answering your questions: 1 - try to use more semantic html tags, such as main, footer, header, you are using too much divs 2 - try to use more id instead of class 3 - I see you're using em for font-size, if you are using em try to set font-size to 62.5% in the html tag, in that way you can treat em unit as px unit, you want to give 10px to the font-size, you can set 1.0em. 4 - for a more responsive layout, try not to set a hard width, you set 320 for the width, but if the device is large the 320 might get small, try to set width in percentage and set a min-width
aside from that, good job
0 - @mpbrunelleSubmitted over 2 years ago
I feel like there should be a more elegant way to space elements vertically on desktop. I used padding top because I couldn't find a way to space them correctly with flexbox or grid. If anyone has a better solution, it'd be great!
