Madan Sinha

Latest comments

• 

  Nathan Lowe•450

  @NathLoweSubmitted almost 2 years ago

  

  Mutlistep Form using NextJS13, Typescript, Zustand, ShadCN, Tailwind

  #next#tailwind-css#typescript#zustand#react

  1

  30
  

  Madan Sinha•300

  @lazy4gyanPosted almost 2 years ago

  @nathlowe you have done a great job 👏

  However, the info step and select plan step must be completed before proceeding to the next step. Adding a required mark or validation error would help users understand this requirement.

  Could you also take a look at my solution and share your thoughts on it?

  Link - Multi-step form using react.js

  Thanks!

  Marked as helpful

  0
• 

  Victor Carvalho•60

  @VictorRego123Submitted almost 2 years ago

  

  NFT Challenge

  2

  40
  

  Madan Sinha•300

  @lazy4gyanPosted almost 2 years ago

  Congratulations 🎉for successfully completing the challenge!

  However, I have noticed few things -

  • you are using non-sematic tag try to avoid them as much as you can, use semantic html tag.
  • avoid defining colors individually to every selector instead use :root pseudo-class for defining global variable and utilize it in your selector as a variable.

  Marked as helpful

  0
• 

  Peace Akaehomen•920

  @PezzyaceSubmitted almost 2 years ago

  

  Huddle landing page with curved sections using HTMl and CSS

  1

  50
  

  Madan Sinha•300

  @lazy4gyanPosted almost 2 years ago

  Hi, your UI is looking perfectly fine.

  However,I have noticed that your styles are breaking for screen size < 375px, due to the your community-container and flowing-conversation-container, use flex-direction:column for these two containers.

  And, most of the mobile screens are above 360px so try to use media queries which can includes all the mobile screens, i.e.

  @media only screen and (max-width: 767px) {
  /* Styles for mobile devices and tablets go here */
  }
  

  0
• 

  Anatoliy•260

  @thenewusSubmitted almost 2 years ago

  

  Fylo data storage

  1

  30
  

  Madan Sinha•300

  @lazy4gyanPosted almost 2 years ago

  Congratulation's buddy 🎉 you have done a fantastic job👏

  However, I noticed that you missed to center the .container class. You can fix this using flex below is the code.

  .container {
  display: flex;
  align-items: center;
  height: 95vh;
  }
  

  0
• 

  keerthi-sogala•70

  @keerthi-sogalaSubmitted almost 2 years ago

  

  Multi step form

  1

  40
  

  Madan Sinha•300

  @lazy4gyanPosted almost 2 years ago

  Congratulations for completing this challenge!🎉

  Following thing's I have notice in your code -

  • In add-on page checkbox is not working properly and prices are not dynamically changing according to monthly/yearly plan. You can use the same logic that you have applied on Select Plan Page by checking the value of obj.kind = val;.
  • You forget to add assets like images, in your repo that's why image is breaking.
  • As you have not added all images in your repo due to which steps are not visible in your stepper as font color:"white"

  At last, I can say you have done a good job👏

  0
• 

  DESALEGN MIHRET•250

  @desalegn12Submitted almost 2 years ago

  

  Frontend Mentor | 3-column preview card component

  1

  70
  

  Madan Sinha•300

  @lazy4gyanPosted almost 2 years ago

  Congratulations🎉 for completing the challenge... you have done a good job.

  @navnithi your GitHub link is not working.

  0