Skip to content
OverviewSolutions
18
Comments
3
Sherif Lawal Itunu
@lawal-sherif-itunu

All comments

  • Sherif Lawal Itunu•230
    @lawal-sherif-itunuPosted over 1 year ago

    Hello there 👋. Congratulation for completing the challenge👍! Please, how did you embed the mobile image into it? I am still searching for that in your code? This is really a great attempt I must say! and can I ask where you learnt your css from?

    0
  • Agnar•220
    @agnar-nomadSubmitted about 2 years ago

    Despite Newbie category, this challenge is harder than I expected. I still have issues with responsive design, despite watching tutorial videos on this.

    All feedback appreciated.

    Product Preview Card Component solution

    1
    Sherif Lawal Itunu•230
    @lawal-sherif-itunuPosted about 2 years ago

    This is a nice work, keep it up. But, it is cool to note that it isn't a nice way of practice to use px in your work rather than rem or em. "Rem and pixel (px) are two units of measurement frequently used in CSS and HTML to define font size, margin or image size for example. However, the two units have a big difference in terms of web accessibility, because a pixel is not responsive and that's why it's better to use REM." Also, you shoudn't have used a fixed width on the card. you could have used stuff like (width: min(90%, 22rem);).

    Also, you shouldn't have given those features to the body rather the div with the class "card".

    moreso, you can use "margin-inline: auto" on the card. that would have made your work centralized rather than pushed to one side

    0
  • Agnar•220
    @agnar-nomadSubmitted about 2 years ago

    This was my very first challenge from frontendmentor and I did it based on a YT tutorial. Very good exercise.

    Order Summary Component solution

    1
    Sherif Lawal Itunu•230
    @lawal-sherif-itunuPosted about 2 years ago

    This is a nice work, keep it up. But, it is cool to note that it isn't a nice way of practice to use px in your work rather than rem or em. "Rem and pixel (px) are two units of measurement frequently used in CSS and HTML to define font size, margin or image size for example. However, the two units have a big difference in terms of web accessibility, because a pixel is not responsive and that's why it's better to use REM." Also, you shoudn't have used a fixed width on the card. you could have used stuff like (width: min(90%, 22rem);). Also, you forgot to give the button with the class of "cancel" a padding. do that

    0