All comments

• 

  tony1610•410

  @tony1610Submitted over 3 years ago

  All comments are welcome!

  

  Using Grid, and trying to stick with the BEM methology

  2

  10
  

  Andrey Larikov•55

  @larikov174Posted over 3 years ago

  Hi!

  • Your page has horizontal scoll from 320px and up to 1440px, should be fixed.
  • Button is interactive element, so you need to add :hover to css with text opacity or some shadows change. And according to classic BEM:

  1. You can't use html tag names as css selector (like h1, h2, body, p is wrong)
  2. You should rename callout--container or callout--top-header because if block has element it should be separate by double underscore like callout__container.

  Marked as helpful

  0
• 

  Hriteek Bista•190

  @hriteekSubmitted over 3 years ago

  Appreciate feedback!!!

  

  Mobile first design

  2

  20
  

  Andrey Larikov•55

  @larikov174Posted over 3 years ago

  Nice job! My opinion: apply uppercase css to your titles. You should add:

  html <h1 class="section__title"> bla bla bla </h1>

  css: .section__title { text-transform: uppercase; }

  MDN Web Docs

  0