All comments

• 

  Michelle•415

  @michellerachoSubmitted almost 4 years ago

  This is my first attempt on a Frontend Mentor Challenge in React. It is also my first time using CSS Modules 😄

  Any feedback would be and is always appreciated especially in how I wrote and split up the components in React. Thank you! 😀

  

  Pricing Component using React useState and styled using CSS Modules

  2

  50
  

  Kevin Canlas•225

  @kvncnlsPosted almost 4 years ago

  Looks great Michelle!

  • It looks like there's a small HTML issue with the label. It shouldn't have a div inside of it.
  • If I had to be nitpicky, I'd just say that the default state should be monthly just like the design comparison. :P

  1

  This comment has received 1 replyShow
• 

  P

  Hamza H.•460

  @hhamza1Submitted almost 4 years ago

  Please review the positioning of the box and bg-patterns if there is any bad practice or a better approach.

  

  HTML/CSS/Vanilla JS - FAQ Accordion Card

  1

  30
  

  Kevin Canlas•225

  @kvncnlsPosted almost 4 years ago

  Hi Hamza, nice work!

  • There's a small bug around the 769px to 1023px media query where the SVG covers the "FAQ" text.
  • Also, the text should change colors on hover.

  Other than that, looks great!

  0

  This comment has received 1 replyShow
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffeSubmitted about 4 years ago

  Hey, everybody! 👋

  I've given a lot of feedback on this particular challenge, and now it's my turn to give it a go! I hope I did okay! 😅

  I ended up coding a lot more Sass and JS than I initially expected, but I learned a lot. I decided to put the slider images in my HTML so that I could use the <picture> element for responsive images but stored the text in my JS (feedback on my JS would be appreciated).

  I added some cool transitions to the mobile menu and navigation and created an intro animation (using GSAP) after stumbling upon this YouTube video and remembering Connor Z did the exact same thing (and blew me away when I saw it) when he completed this challenge! 😆

  More importantly, I tried to ensure that the design scales up and down nicely (which gave me quite a headache because of this behavior of flexbox), but I think I managed to do it okay in the end.

  Of course, feedback is welcome and appreciated! 😊

  Happy coding, everyone! 😁

  

  Room Homepage with CSS Transitions and JS (GSAP) Animations

  9

  2414
  

  Kevin Canlas•225

  @kvncnlsPosted almost 4 years ago

  Hey APG! Your site is awesome! Can I ask how you made the navbar close when you have it open on mobile/tablet size then expand to desktop size?

  So let's say your window was 500px width, you open the navbar menu, then you expand the window passed the navbar menu limit (where the hamburger menu should disappear). How did you get the navbar to close automatically? I don't think I saw an event listener on window resize.

  1

  This comment has received 1 replyShow
• 

  Jerline•190

  @jerline01Submitted almost 4 years ago

  

  Html, CSS, Bootstrap

  1

  10
  

  Kevin Canlas•225

  @kvncnlsPosted almost 4 years ago

  Use the Dev Tools and check your layout at 375px width (iPhone X size). The purple background quote sticks out of the card. I used 375px because that's what the style guide said (375px and 1440px). The text also gets too narrow, so it's probably a padding issue.

  1

  This comment has received 1 replyShow