All comments

• 

  Konstantin Kamenskiy•50

  @Grendaizo90Submitted almost 2 years ago

  Please tell me about bad practices in my code :)

  

  QR Code Component

  1

  20
  

  krisskross69•70

  @krisskross69Posted almost 2 years ago

  Congrats!!! Your code looks really good here are a few tweaks i think might be helpful;

  HTML:

  1. It would be nice to make your code more accessible to screen readers and others by dividing them with more specificity that is making more use or "<main></main>, <section></section>, <footer></footer> where they would be appropriate.
  2. You can also make use of an h1 (but you would have to make it hidden) just for screen readers too.

  I am still learning though just thought i should share hope you find it helpful. Your css looks really nice

  Marked as helpful

  1