Design comparison
SolutionDesign
Solution retrospective
Please tell me about bad practices in my code :)
Community feedback
- @krisskross69Posted almost 2 years ago
Congrats!!! Your code looks really good here are a few tweaks i think might be helpful;
HTML:
- It would be nice to make your code more accessible to screen readers and others by dividing them with more specificity that is making more use or "<main></main>, <section></section>, <footer></footer> where they would be appropriate.
- You can also make use of an h1 (but you would have to make it hidden) just for screen readers too.
I am still learning though just thought i should share hope you find it helpful. Your css looks really nice
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord