Skip to content
OverviewSolutions
4
Comments
3
Stefan Kremenovic
@kremenovic

All comments

  • Stefan Kremenovic•225
    @kremenovicPosted about 2 years ago

    Hey David, I was checking your portfolio and bumped into this project. Looks really good, but I've found a small bug on the site.

    After ordering and if user doesn't close the popup (order confirmation) and goes to the homepage or any other page overlay is gonna stay active > https://prnt.sc/qgaj-84zB18B

    Best,

    Stefan

    Marked as helpful
    0
  • Stefan Kremenovic•225
    @kremenovicPosted almost 3 years ago

    Hey man, I see that you deployed your app on Netlify too. There's an issue with Netlify when you are on another page (not home) and when you reload it says "Page not Found". Here's the fix for that:

    https://www.youtube.com/watch?v=JCM_xoWbF70

    Marked as helpful
    1
  • Stefan Kremenovic•225
    @kremenovicPosted over 3 years ago

    Hi, I would recommend you to start using width: 100% instead of let's say 1580px; You may use max-width: 1500px; width: 100%; that way your code will be responsive, and it will be easier to fix some styling issues for the mobile devices.

    This is how it looks like on my laptop, and I added 100% to fix it > http://i.prntscr.com/zFSYMmiaRzyFmaK31yaqpw.png

    The next thing is your HTML structure, please take a look > http://i.prntscr.com/YkcfSNcnQneGLh9DFikTQA.png

    This should be in one container(div), and inside of that container, you would have 2 columns. So the content goes inside of those columns, and it would be easier to position them using display: flex. I see you were using position: absolute with padding 781px and that's a big no-no in my opinion.

    Next thing, attribution comes last in your HTML structure, but on the desktop, it's on the top, and for the mobile, it's on the bottom as it should be, so try to fix that.

    Oh yea, the .picture div goes of the text so there is no chance to select the text if you want to copy or to mark it or to inspect that element. It will inspect the picture, and the reason for that is the padding-left that's pushing the picture.

    I hope this will help you.

    Marked as helpful
    2