Audiophile-Ecommerce (React, React-Router, Redux-toolkit, SASS, Grid)

Community feedback

• 

  Stephen Addae•270

  @Stephen-AdomPosted about 2 years ago

  Hello David, just checked your site it looks good on desktop as well as mobile. The router link breaks when I refresh the page and also the user has to know which page he/she is on so you need to highlight the nav links as well. For the routing issue, I think you should define your routes in your index.js file and use outlet tag in your app.js file to define your root outlet path for your site pages

  So your app.js file will look like the function below;

  function App() { return ( <div className="App main-layout"> <Wrapper> <Overlay /> <Navbar /> <Outlet /> <Footer /> </Wrapper> </div> ); }

  And your index.js file will be as

  root.render( <React.StrictMode> <Provider store={store}> <PersistGate persistor={persistor}> <BrowserRouter> <Routes> <Route path="/" element={<App />}> <Route index=true element={<Home />} /> <Route path="category/:categoryName" element={<Category />} /> <Route path="product/:productSlug" element={<Product />} /> <Route path="checkout" element={<Checkout />} /> </Route> </Routes> </BrowserRouter> </PersistGate> </Provider> </React.StrictMode> );

  Hopes this helps :)

  Marked as helpful

  1

  ---

  

  David•1,130

  @David-Henery4Posted about 2 years ago

  @Stephen-Adom Thanks for the feedback! Great suggestion on the nav links, I didn't even think of highlighting them like that.

  Also a great find on the broken router links and solution as well! I have now implemented both and everything seems to be fixed and working well now!

  Thank you again for the great feedback Stephen, very much appreciated thank you! 👍

  1

  

  Stephen Addae•270

  @Stephen-AdomPosted about 2 years ago

  @David-Henery4 Glad to be of help

  0
• 

  Stefan Kremenovic•225

  @kremenovicPosted about 2 years ago

  Hey David, I was checking your portfolio and bumped into this project. Looks really good, but I've found a small bug on the site.

  After ordering and if user doesn't close the popup (order confirmation) and goes to the homepage or any other page overlay is gonna stay active > https://prnt.sc/qgaj-84zB18B

  Best,

  Stefan

  Marked as helpful

  0

  ---

  

  David•1,130

  @David-Henery4Posted about 2 years ago

  @kremenovic Hello Stefan, thanks for checking out the project and finding that bug, I didn't realise it was there! I will sort it out as soon as I can.

  Thank you for the feedback Stefan, I appreciate it a lot 👍

  1