Frontend Mentor | Kevin Irias's profile

@abdurrahmanfahimSubmitted 9 months ago

i created it

#accessibility#airtable#animation

@kiriasruPosted 9 months ago

Your HTML structure is generally good. Keep in mind using semantic tags. You should wrap everything in a main tag.
It seems that you don't have the asset's folder, so images won't load.
Add a descriptive alt attribute to <img> (alt="QR code" for example). It helps users who rely on screen readers understand the content of the image.
Add some margin-bottom in <p class="highlight">Learning</p>

0

@ArjayGithub-devSubmitted 9 months ago

@kiriasruPosted 9 months ago

0

@Eswararao777Submitted 9 months ago

@kiriasruPosted 9 months ago

Nice!!! Take the following into account:

You should wrap everything in a semantic tac (<main></main>)
Change the background-color
Add some padding (around 17px) to the <div class="qrContainer">
Add a descriptive alt attribute to <img> tag (alt="QR code" for example). It helps users who rely on screen readers understand the content of the image.

0

@nais-4Submitted 9 months ago

What are you most proud of, and what would you do differently next time?

I'm proud enough that I actually finished this project.

What challenges did you encounter, and how did you overcome them?

I had difficulty centering the QR Code vertically. I watched Kevin Powell's videos to get an understanding of Flexbox more.

@kiriasruPosted 9 months ago

Your HTML structure is generally good. I'd be great if you wrap everything in a semantic tag <main>
The QR code component is visually clear, but there is room for an accessibility improvement, which is adding a descriptive alt attribute to <img> tag (alt="QR code" for example). It helps users who rely on screen readers understand the content of the image!

1