QR Code Component using HTML and CSS

Community feedback

• 

  Shakil ahmed•260

  @Shakil-aPosted 4 months ago

  Great job on completing the challenge Kevin! , suggestions for improvement would be:

  • always include a main in your index.html and put all your code into that

  • instead of fixed width sizes, have it as max-width so it is more responsive, I know this challenge doesn’t go into that but it’s best to practise now before you learn about responsive design and how to apply it

  • for font size rather than using pixels, use em or rem ( search up the reasons why it’s better practise )

  • and for height apply min-height in most cases rather than height ( so remember for widths we want max-width and for setting heights min-heights, you can search up the benefits and understand why )

  Other than that, very good job on the challenge.

  Marked as helpful

  1