Ahmed-hdj• 150
@Ahmed-hdj
Submitted
Juriya
@juriya
All comments
- Juriya• 140
@juriya
Posted
Congratulations on completing the challenge!!
Your solution looks good on a range of screen sizes but with little improvements it looks even great. Here are some things which I would like to suggest:
- I have noticed you are using
<div>to create divisions in your template. Instead you can consider using semantic elements like<main>,<article>and<section> - For layout, instead of using width, you can use flexbox or grid for this challenge
Hope this is helpful!!
Marked as helpful
0 - I have noticed you are using
- Rodri• 100
@rcsilva211
Submitted
What are you most proud of, and what would you do differently next time?
I was able to revise and use on both width and height, as well as use calc to have responsive font-sizes, as well clamp on both the width and height, and all this combined has made me see that it did a much better job on responsiveness.
What challenges did you encounter, and how did you overcome them?
Definitely doing responsivess from scratch. I understand the main concept, but I think I've written a lot more lines than originally necessary. Other than that, the concepts are pretty clear to me.
What specific areas of your project would you like help with?
Help in recognizing where I could've done better or how in terms of the code done. Exe: what could I do to make everything more responsive in less lines of code.
Juriya• 140@juriya
Posted
Congratulations on the solid solution!
It could benefit from using semantic HTML elements like
<main>and<section>instead of relying solely on<div>tags for better accessibility and structure. Overall, the layout is good, but incorporating semantic elements would enhance readability and alignment with best practices.0 - Princekumar7999• 10
@Princekumar7999
Submitted
Juriya• 140@juriya
Posted
Congratulations on completing the challenge!
To further enhance your solution, consider a few key areas:
- Start by refining your use of semantic HTML—replacing generic
<div>elements with more meaningful tags like<section>or<article>will provide better document structure and clarity. - For responsiveness, implement media queries to adapt the layout for various screen sizes and use flexible design techniques like responsive units and grid layouts.
- In some areas, I have noticed you are using
for spacing the text; instead you can use table with full width or flex container to eliminate the need for fixed spacing in our template.
Hope this is helpful!!
0 - Start by refining your use of semantic HTML—replacing generic
- SamuelKamal13• 70
@SamuelKamal13
Submitted
Juriya• 140@juriya
Posted
The solution uses accessible, well-structured code that aligns with the design and adapts to various screen sizes. Replacing
<div>with semantic elements like<main>,<section>, and<header>could improve clarity. Overall, the implementation is commendable.0 - P
@chcoutinho
Submitted
Juriya• 140@juriya
Posted
Great job on using semantic HTML effectively and maintaining well-structured, readable code. The design is nearly spot-on and accessible, which is commendable. However, to improve responsiveness, especially on smaller screens, consider implementing media queries and flexible layouts to prevent cropping. Overall, the work is strong, and with a few tweaks for responsiveness, it will be even better.
Marked as helpful
0 - Helmi Sulaemi• 40
@helmisulaemi
Submitted
Juriya• 140@juriya
Posted
The solution effectively uses semantic HTML and is accessible. The layout performs well across various screen sizes, but minor adjustments to text padding are needed to match the design precisely. Overall, the code is well-structured, readable, and reusable, and the implementation closely aligns with the design.
Marked as helpful
0
