@juriya
Posted
Congratulations on completing the challenge!!
Your solution looks good on a range of screen sizes but with little improvements it looks even great. Here are some things which I would like to suggest:
- I have noticed you are using
<div>
to create divisions in your template. Instead you can consider using semantic elements like<main>
,<article>
and<section>
- For layout, instead of using width, you can use flexbox or grid for this challenge
Hope this is helpful!!
Marked as helpful
@Ahmed-hdj
Posted
@juriya Thank you for your comment for the first point i will start using them soon for improving accessibility and for the second point this was my first project and i wasn't comfortable with flex and grid but in my newest projects i used flesbox and grid most of times . Thank You Your comment was helpful