Skip to content
OverviewSolutions
8
Comments
7
Jun Wei
@junwei-wong

All comments

  • Mateus Lima•360
    @mts-mlSubmitted 3 months ago
    What challenges did you encounter, and how did you overcome them?

    Had some trouble getting the design right, don't have access to the Figma files, so, some aspects maybe off.

    What specific areas of your project would you like help with?

    I would like tips and constructive criticism.

    Testimonials Grid Section challenge

    1
    Jun Wei•200
    @junwei-wongPosted 3 months ago

    Nice work, I just completed challenge and felt it's really tough to just use grid.

    Here are some feedbacks:

    • For the Verified Graduate and the description <p>, can consider the tip from the style guide md file on using the opacity:50% or 70% property to make it closer to the design rather than hardcoding the color.
    • This one is more of an alternative I recently learned which I find it pretty cool, is that we can use css to inject the quotation svg into the background instead.
      background-image: url(../images/bg-pattern-quotation.svg);
  background-size: 7rem 7rem;
  background-repeat: no-repeat;
  background-position: top right 18%;
    Marked as helpful
    0
  • Jun Wei•200
    @junwei-wongPosted 3 months ago

    Really clean solution. Some feedback on my end:

    • In the design, I noticed that the heading font-size is bigger for larger screens and smaller for smaller screens. You can use the clamp function for the heading, e.g. font-size: clamp(1.55rem, 5vw, 2.25rem);. This should adjust to a bigger and smaller screen size.
    • The p tag in the header lacks a max width, something like 32rem should do the trick.
    • For mobile screen size, the headers lacks a text-align:center.

    Keep up the good work!

    Marked as helpful
    0
  • JackEG•90
    @Yakub357Submitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    I am glad completing this challenge, especially when doing the responsiveness part of the challenge. Because, when I started the challenge, I started with desktop design, and when doing the mobile design with media queries, I added up a lot CSS writing and a lot of tweaking. After a search in YouTube, I noticed that best and optimal solution would be when the challenge started from structured HTML and then mobile first design coding. It boosted my writing code process.

    What challenges did you encounter, and how did you overcome them?

    Challenges related to media queries for mobile design, spacing issues while working with flex-box and grid properties of the elements.

    What specific areas of your project would you like help with?

    I would add more animation, like fade in, fade out, hover effects, etc.

    Product preview card component

    1
    Jun Wei•200
    @junwei-wongPosted 3 months ago

    Wicked cool! It's almost identical to the design. If I had to be nitpicky, only the spacing between price and price--old is a bit wider in the design. Your code is pretty neat too.

    Keep it up.

    Marked as helpful
    1
  • Jun Wei•200
    @junwei-wongPosted 3 months ago

    Nice work completing the challenge. Here are some feedbacks from me:

    • using px for font size is not really responsive when I switched to mobile view. Try to use rem or em for sizing.
    • the li::marker are missing the colors when compared to the design. You can target them with the css below:
      ul ::marker {
    /* works */
  }

  li::marker{
    /* works */
  }
    • the td is the 2nd column of the table font color is different from the design
    Marked as helpful
    0
  • Jun Wei•200
    @junwei-wongPosted 3 months ago

    Nice work, here are some feedbacks:

    • do try to include the alt value attribute in img tags for accessibility
    • it's good practice to keep the file names in lowercase letters e.g. style.css instead of Style.css
    • spelling on the name Jessica is missing an 'a'
    Marked as helpful
    0
  • Jun Wei•200
    @junwei-wongPosted 3 months ago

    Your code is pretty neat.

    Some nitpicking feedback would be:

    • increasing the padding on the blog card
    • increasing the line-spacing for the blog description

    Semantic feedback:

    • there is a html tag called time for displaying date time which you could try out
    Marked as helpful
    0
  • Jun Wei•200
    @junwei-wongPosted 4 months ago

    Referring to your style.css file, I haven't noticed any usage of box shadow. Here is what I did for adding shadow: box-shadow: 9px 11px 20px 0px rgb(140 137 137 / 20%);

    For reference, W3Schools

    Keep up the good work!

    0