Skip to content
OverviewSolutions
21
Comments
5
Joshysmart
@joshysmart

All comments

  • Joshysmart•840
    @joshysmartPosted almost 2 years ago

    Thank you for taking the time to provide feedback on my solution. Let me address some of the issues you raised

    1. Looks like there may be some issues here from looking at the design comparison above. It looks good on my phone though I changed the design in my solution and moved the project section into a new page that is why there is a discrepancy between my front page and the generated screenshot

    2. That said, you definitely have some issues with accessibility and html structure here. I’ve only looked at the contact component but noticed i. there’s no form element There is a form element. I am handling the form using remix.run

    ii. the button is missing a type attribute I have now added a type attribute

    iii. no inputs are labelled (it’s not enough to wrap in a label tag, they need content) I have added a for attribute to the input if that isn't what you mean please help me clarify

    iv. errors are not programmatically linked to their inputs the form validation and errors are handled at the backend I have modified the solution to maintain the form position after submission so any error is visible to the user.

    v. errors have no aria-live attributes I have added the attribute to the error elements. This is new to me thanks for pointing that out

    vi. there’s no form validation, even the basic html kind I have added basic HTML validation I initially left out but there is still validation for the inputs in the backend

    0
  • Joshysmart•840
    @joshysmartPosted almost 4 years ago

    Thank you so much for taking the time to review my solution I learned a lot. I have refined the animation. I hope this is better?

    0
  • Joshysmart•840
    @joshysmartPosted about 4 years ago

    @justAdevTV @davidomarf thank you for your response. it means so much. I have improved the responsiveness and I'd appreciate it if you can go over it again..

    0
  • Joshysmart•840
    @joshysmartPosted about 4 years ago

    If I add some things to the filters, and then manually remove them by deleting one by one, the list doesn't update. Even if I end up with 0 filters.

    it works fine on my local server. I will look into it.. thank you so much for inspecting and giving me feedback i appreciate your response

    0
  • Joshysmart•840
    @joshysmartPosted about 4 years ago

    Can you try deploying it with vercel, or github?

    0