Skip to content
OverviewSolutions
4
Comments
4
José Rodríguez
@josergz

All comments

  • José Rodríguez•90
    @josergzPosted over 2 years ago

    Hello, I want to provide feedback.

    1. Desktop and mobile design, look good.
    2. I recommend you research and use semantic html tags and not put everything inside "divs" as this is not a good practice.
    3. Images should have something in the "alt" attribute to improve accessibility

    Overall good job, good luck :)

    0
  • José Rodríguez•90
    @josergzPosted over 2 years ago

    Hello, I want to provide feedback.

    1. On my desktop your design looks overwhelmed, I don't know if it has to do with the resolution of the screen.
    2. In the readme.md you can make the image display directly using the image path " "
    3. Your html looks good, you could use more semantic tags
    4. Mobile design looks good

    Overall good job, good luck :)

    Marked as helpful
    0
  • Julia•210
    @yulich81Submitted over 2 years ago

    I used linear-gradient to create transparent purple overlay for img:

    background-image: linear-gradient(90deg, rgba(120, 9, 121, 0.45) 35%, rgba(120, 9, 121, 0.45) 100%), url(./images/image-header-desktop.jpg);

    Stats preview card with grid and flexbox (corrected)

    2
    José Rodríguez•90
    @josergzPosted over 2 years ago

    Hello, I want to provide feedback.

    1. ❓ It looks like the desktop layout has a vertical scroll, using google chrome tools it looks like the detail is the size of the footer.

    2. ✅ in the html you use semantic tags, that's good.

    3. ❓ The readme.md file, it doesn't show the screenshot, it looks like you have an error in the image path.

    4. ✅ You solved well the use of color in the image, I used the css filter property, you can investigate about it.

    5. ✅ The mobile layout looks good.

    Overall good job, good luck:)

    Marked as helpful
    1
  • José Rodríguez•90
    @josergzPosted over 2 years ago

    Hello, I want to provide feedback. Mobile layout doesn't look good on some resolutions. You can opt to use semantic tags in the html and not use much div. Every image must have something in the alt attribute, to improve accessibility. In your css you refer to the footer, but in your html there is no footer tag. I wish you the best, good job

    0