José Rodríguez
@josergzAll comments
- @NourAldinShSubmitted over 2 years ago@josergzPosted over 2 years ago
Hello, I want to provide feedback.
- Desktop and mobile design, look good.
- I recommend you research and use semantic html tags and not put everything inside "divs" as this is not a good practice.
- Images should have something in the "alt" attribute to improve accessibility
Overall good job, good luck :)
0 - @Karlof99Submitted over 2 years ago
Hello friends, How could I improve responsiveness? It seems that I get it in 375px and 1440px, but not for other sizes. Regards
@josergzPosted over 2 years agoHello, I want to provide feedback.
- On my desktop your design looks overwhelmed, I don't know if it has to do with the resolution of the screen.
- In the readme.md you can make the image display directly using the image path " "
- Your html looks good, you could use more semantic tags
- Mobile design looks good
Overall good job, good luck :)
Marked as helpful0 - @yulich81Submitted over 2 years ago
I used linear-gradient to create transparent purple overlay for img:
background-image: linear-gradient(90deg, rgba(120, 9, 121, 0.45) 35%, rgba(120, 9, 121, 0.45) 100%), url(./images/image-header-desktop.jpg);
@josergzPosted over 2 years agoHello, I want to provide feedback.
-
❓ It looks like the desktop layout has a vertical scroll, using google chrome tools it looks like the detail is the size of the footer.
-
✅ in the html you use semantic tags, that's good.
-
❓ The readme.md file, it doesn't show the screenshot, it looks like you have an error in the image path.
-
✅ You solved well the use of color in the image, I used the css filter property, you can investigate about it.
-
✅ The mobile layout looks good.
Overall good job, good luck:)
Marked as helpful1 -
- @rfajrinandipintoSubmitted over 2 years ago@josergzPosted over 2 years ago
Hello, I want to provide feedback. Mobile layout doesn't look good on some resolutions. You can opt to use semantic tags in the html and not use much div. Every image must have something in the alt attribute, to improve accessibility. In your css you refer to the footer, but in your html there is no footer tag. I wish you the best, good job
0