Stats preview card with grid and flexbox (corrected)

Community feedback

• 

  José Rodríguez•90

  @josergzPosted over 2 years ago

  Hello, I want to provide feedback.

  1. ❓ It looks like the desktop layout has a vertical scroll, using google chrome tools it looks like the detail is the size of the footer.

  2. ✅ in the html you use semantic tags, that's good.

  3. ❓ The readme.md file, it doesn't show the screenshot, it looks like you have an error in the image path.

  4. ✅ You solved well the use of color in the image, I used the css filter property, you can investigate about it.

  5. ✅ The mobile layout looks good.

  Overall good job, good luck:)

  Marked as helpful

  1

  ---

  

  Julia•210

  @yulich81Posted over 2 years ago

  @josergz thanks for the feedback! I've checked the desktop layout, it seems fine both on Firefox and Chrome. But I'll keep in mind to double check it.

  You are absolutely right about the screenshots. I forgot to update github repository. Thanks :)

  Again, many thanks for the feedback. It was helpful.

  0
• 

  idukpaye alex•725

  @Esesosa-maxPosted over 2 years ago

  1. ✅ Good Looking Desktop Design 4.5/5
  2. ✅ Well structured, readable 4/5
  3. 🆗 Responsiveness 2/5
  4. ✅ Good Application of CSS Variables 4/5
  5. ✅ Personal Advice : you do not need you the background-image property just use The CSS Filter property it is way easier. Here is a Reference Link

  Marked as helpful

  1

  ---

  

  Julia•210

  @yulich81Posted over 2 years ago

  @Esesosa-max thank you for the feedback. I will try filter property, haven't heard about it yet.

  0

  

  idukpaye alex•725

  @Esesosa-maxPosted over 2 years ago

  @yulich81 , it is Quite mysterious. you can mark the commet as helpful if it help you

  0