Skip to content
OverviewSolutions
4
Comments
4
jopeeter
@jopeeter

All comments

  • jopeeter•60
    @jopeeterPosted about 2 months ago

    There's a lot of difference with the solution and the design, i think it could be because the design preview is just an image and doesn't have the sizing to follow. It would be a great help to check Coder Coders full Process of making a responsive website, she has a great tip on how to check sizes of the content.

    Marked as helpful
    0
  • Adam Whitehouse•130
    @adamwhitehouse95Submitted 2 months ago
    What are you most proud of, and what would you do differently next time?

    Happy to have completed the project without too many issues. Regular commits and Google helped me finish. Next time i would add an image of myself instead.

    What challenges did you encounter, and how did you overcome them?

    I didnt know how to transisition out, but found a neat article explaining you have to place a transition on the non-pseudo element for the transition out and a transition on the pseudo element for the transition in.

    What specific areas of your project would you like help with?

    I would really like to know how my code is, any problems, anything i could improve on. Some feedback would be greatly appreciated because i feel confident but i know its not perfect and without guidance i wont know what to change.

    Social Links Profile

    3
    jopeeter•60
    @jopeeterPosted 2 months ago

    Well done !

    0
  • jopeeter•60
    @jopeeterPosted 2 months ago

    while doing this challenge i was wondering if i can nest all media changes on the media query itself, because my way, i put a media query on all the class that i need it, but by checking your code , my question was answered and it can be done.

    as for your code, first thing that's noticeable is that the card is not properly center, i see that you use flex to center it. For me i prefer the left-top margin with translate , next time i will try to use flexbox the way you use it.

    everything is on point, except the positioning and the missing border. great job!!

    0
  • jopeeter•60
    @jopeeterPosted 2 months ago

    I leek the way you approach the html nesting, its has lesser tags than my method, i check your styling, you followed the style guide but have some differences with the preview mainly because of the padding. As a beginner myself i will suggest having a better understanding with the box model.

    0