Skip to content
Submitted 2 months ago

Social Links Profile

Adam Whitehouse•130
@adamwhitehouse95
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Happy to have completed the project without too many issues. Regular commits and Google helped me finish. Next time i would add an image of myself instead.

What challenges did you encounter, and how did you overcome them?

I didnt know how to transisition out, but found a neat article explaining you have to place a transition on the non-pseudo element for the transition out and a transition on the pseudo element for the transition in.

What specific areas of your project would you like help with?

I would really like to know how my code is, any problems, anything i could improve on. Some feedback would be greatly appreciated because i feel confident but i know its not perfect and without guidance i wont know what to change.

Community feedback

  • Grace•31,070
    @grace-snowPosted 2 months ago

    This has some of the same issues as previous challenges

    • this one is missing the css reset, or you've chosen to change it and broken your solution in the process by limiting the body height to 100vh.
    • main also has a limited height when it needs to not have one.
    • there are unnecessary css properties throughout like letter spacing 0rem.
    • This has incorrect html. These social links would navigate somewhere so that tells you they need to be links not buttons. In this case I'd also expect them to be inside list items in an unordered list.

    Hopefully that's helpful alongside previous feedback.

    2
    Grace•31,070
    @grace-snowPosted about 2 months ago

    This now has invalid html. You can't have links inside buttons or vise versa. They are distinct elements each with a different purpose.

    It would be helpful to have them in a list as mentioned too.

    0
  • LuccaMauroMolina•130
    @LuccaMauroMolinaPosted about 2 months ago

    Esta muy bueno, lo unico que arreglaria el css, o sea ajustaria la card para que sea mas chica y le pondria cursor en cada uno de esos botones para que quede mejor, pero esta bastante bueno

    0
  • jopeeter•60
    @jopeeterPosted 2 months ago

    Well done !

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord