Skip to content
OverviewSolutions
12
Comments
6
Carl Jones
@jones9411

All comments

  • Carl Jones•200
    @jones9411Posted almost 3 years ago

    Not a problem but instead of having different pages for everything which slows down your website a lot, and the constant loading of new pages is a bit jarring, for example instead of having three HTML pages for the Destination page you could have had just one and used javascript to dynamically alter the page content.

    Marked as helpful
    1
  • Carl Jones•200
    @jones9411Posted about 3 years ago

    hi @ArtemVMV, you attached the background images to the HTML selector in the CSS, try instead attaching them to the body tag instead.

    Marked as helpful
    1
  • Carl Jones•200
    @jones9411Posted about 3 years ago

    Hi @st3wn, you could add something like " box-shadow: 0px 3px 12px 0px rgba(0, 0, 0, 0.26); " to the .block in your css file, should apply to all for of your blocks this way.

    You could also use this to learn more about making box shadows
    https://html-css-js.com/css/generator/box-shadow/

    0
  • Djordje•70
    @DjokarasSubmitted about 3 years ago

    How should I make my grid responsive while still on higher resolutions before media queries?

    CSS Grid Flexbox

    1
    Carl Jones•200
    @jones9411Posted about 3 years ago

    hi @djokaras,

    you have put the container width at 75%, this will be true on smaller screens as well, so the content within will over flow onto the rest of the page. try setting a min-width first then set a width that fits the content after. Also you need to use the background no-repeat fot the background images.

    Marked as helpful
    1
  • Carl Jones•200
    @jones9411Posted about 3 years ago

    Hi, it appears that when you load into the page that the error message is already there, you should add the eventlistener to the on-click of request access button. This way it's only when the form button is clicked will the error show itself. e.g button is clicked => check if there is a valid email => if not show error message => if there is show pop up message. This is the work flow I will implement for this challeng. Hope this helps

    1
  • Danny•10
    @Danny-forSubmitted about 3 years ago

    Hey, guys !! this is my first developed challenge, i hope i managed to apply the correct concepts of HTML and CSS. Please, if I can improve anything, let me know!!! thankful .

    Order Summary | challenge html and css

    3
    Carl Jones•200
    @jones9411Posted about 3 years ago

    HI @danny-for,

    Good job on the solution, I've just done this one myself as well. The advice I was given was to use more semantic HTML tags like main, section, header, etc.

    Also maybe use some more padding/margin to add a little bit more space between elements

    Well done, Carl

    Marked as helpful
    2