Order Summary | challenge html and css

Community feedback

• 

  P

  Dave•5,295

  @dwhensonPosted about 3 years ago

  Hey @Danny-for congrats on completing your first challenge! 🙌

  I think it looks good, and you've made good use of flex to align things nicely.

  Some small suggestions:

  1. Maybe try a couple of different options on the middle flex container to see what layout matches - I wondered if space-around might work? Not sure though!
  2. A neat trick to center components like this on the page it to set display: grid on the body, along with place-content: center; and min-height: 100vh; - this should help you with a few challenges

  Keep up the good work! 👍

  Cheers 👋

  Dave

  Marked as helpful

  5

  ---

  

  Danny•10

  @Danny-forPosted about 3 years ago

  ohh Thank you! @dwhenson, I will try to put into practice your suggestions/feedback on how to centralize the components.

  success 👋🏽 Thank you so much

  • Danny

  0
• 

  hardy•3,660

  @hardy333Posted about 3 years ago

  Hi, this is great result for the first time - good job.

  Few suggestion:

  • Make button full width of its container so that it will be the same size as .container__plans.
  • use smaller font-size on paragraph text
  • Button hover state background-color is too gray, try to change it and add box-shadow also.

  Marked as helpful

  2

  ---

  

  Danny•10

  @Danny-forPosted about 3 years ago

  hello @hardy333 ! , thanks so much for the feedback . I will try to improve it.

  Thank you so much !

  • Danny

  0
• 

  Carl Jones•200

  @jones9411Posted about 3 years ago

  HI @danny-for,

  Good job on the solution, I've just done this one myself as well. The advice I was given was to use more semantic HTML tags like main, section, header, etc.

  Also maybe use some more padding/margin to add a little bit more space between elements

  Well done, Carl

  Marked as helpful

  2

  ---

  

  Danny•10

  @Danny-forPosted about 3 years ago

  Hi @jones9411, thank you very much for the feedback I will try to put it into practice and congratulations for developing this challenge too.

  Thank you so much !

  -Danny

  0