Skip to content
OverviewSolutions
5
Comments
3
Kazi Monirul Islam
@johnny064

All comments

  • Ioan•300
    @ioangheraszimSubmitted about 2 years ago

    Finally finished this project. Input is appreciated especially on the JS part. Learn a lot about the DOM along the way.

    Interactive details form HTML CSS JS

    1
    Kazi Monirul Islam•140
    @johnny064Posted about 2 years ago

    Ok here are some suggestions to improve yourself:

    1. you should not put an action attribute in the input tag cause you have already put an action in the form tag. your code
    <input class=`submitBtn` type=`submit` action=`submit` value=`Confirm`>

    code should be like this:

    <input class=`submitBtn` type=`submit` value=`Confirm`>

    Also, a button should not have "action = ' ' ".

    *** Please see the HTML validation after the solution submits. there you can know the error and suggestions. It will help you to improve @ioangheraszim

    Thanks Kazi

    0
  • Cristina•360
    @cr1deg0Submitted about 2 years ago

    Hi,

    Great challenge! I decided to use chart.js to build the solution. It's my first time using this library and I can say it's really cool, highly recommended! As the graph is a <canvas> element I've added aria-role and aria-label via javascript to make sure the solution is accessible.

    As always, feedback is welcome! Cristina

    Expenses chart component with chart.js

    1
    Kazi Monirul Islam•140
    @johnny064Posted about 2 years ago

    Good job. Much learn from your JS. Is it some kind of library (chart.js) or did you build it from scratch?

    Just one suggestion I think. You always use header tags sequentially like:

    <h1> <h2> <h3> <h4> <h5> <h6>

    It is good practice for accessibility and SEO for the future.

    But thanks a lot CRISTINA @cr1deg0.

    Marked as helpful
    0
  • Kazi Monirul Islam•140
    @johnny064Posted about 2 years ago

    @Maryan121 Hello bro. Though you have not yet added the script file. It's hard to say. But I have looked at your code. Here is some issue I have found.

    *** You should use the <h> by likewise like:

         
    <h1><\h1>
   <h2><\h2>
   <h3><\h3>
   <h4><\h4>
   <h5><\h5>

    *** You should use this format:

    <header></header>
<main></main>
<footer></footer>

    it will give your code more accessibility.

    *** And please write comments to your code. All HTML, CSS, Javascript. So that anyone can understand your code easily.

    Thanks If have any issue you can tell me here.

    Marked as helpful
    0