Skip to content
OverviewSolutions
6
Comments
5
john
@johnhaab

All comments

  • Cloud Custodian•80
    @joeterleckiSubmitted over 1 year ago

    I continued with everything I learned up to this point from my previous feedback; however, there is one small prob I can't solve.

    For some reason after setting a width and height to the parent container div and setting the image to fill, the header length is slightly longer than the width resulting in the overlay busting out of the parent div by ~5 pixels. If anyone can help me out with what's wrong with that, I would be grateful.

    Also, all other feedback is welcomed.

    NFT Preview Component | HTM & CSS Responsive Design

    3
    john•90
    @johnhaabPosted over 1 year ago

    Good job on completing this challenge, it looks great!

    As for your issue from looking at the inspect element, your parent div to the img has a total height of 309px, and your img has a total height of around 303. Try and locate the error by researching, removing styles and tweaking the styles.

    I managed to fix your issue by changing "height: 100%" to "height: 98%" inside your ".card-header:hover::before" class.

    Nonetheless great job.

    0
  • Abelardo Gomez Rodriguez•30
    @abelgmzSubmitted almost 2 years ago
    • I would like to know what would be the best option to work with downloaded fonts and use them...
      • Option 1 - only one folder with all fonts
        • fonts-folder
          • font1.ttf
          • font2.ttf
      • Option 2 - folder with subfolders for each font
        • fonts-folder
          • font1-folder
            • font1.ttf
          • font2-folder
            • font2.ttf

    Recomendations are welcome, thanks :)

    Responsive product preview card using flexbox and sass

    4
    john•90
    @johnhaabPosted almost 2 years ago

    I agree with srayala42 and, Zeyad Mohamed.

    Use google fonts, its amazing also use Font Awesome. Font Awesome is the easy way to get great icons for free and they're SVG! (look up on Youtube to get them setup)

    0
  • john•90
    @johnhaabPosted almost 2 years ago

    LOOKS FINE ON WEBSITE, LOCALHOST, MY PHONE BUT NOT THIS LOL WHAT

    0
  • john•90
    @johnhaabPosted almost 2 years ago

    not sure why it looks like that in the preview it looks fine on the website its hosted on?

    0
  • Lucas Bailo•100
    @lucasbailoSubmitted almost 2 years ago

    In this case my problems were related to image sizing when it's related to the margins of the cointainers. Sometimes I was using padding and others margin, but the final result was quite good for me!

    Flex box

    3
    john•90
    @johnhaabPosted almost 2 years ago

    I removed the <div class="attribution"> in mine as it caused issues.

    And to center the content better you should add min-height:100vh; to the body. And reduce the width value of main_container.

    I am new so take what I say with a grain of salt but it worked well for me on this. <3

    Marked as helpful
    1