Skip to content
OverviewSolutions
1
Comments
2
Joe Cox
@joejcox

All comments

  • Joe Cox•80
    @joejcoxPosted almost 3 years ago

    Looking good but I would work on the routes.

    When you visit a country the pathname is just /country. It would be good if the user could load this page initially and view the content. Instead, on refresh or first load at this path you get a 404 error as either the app doesn't know what country to load as no default is given because everything is client side. There are ways around it but you'd need to at least update the pathname to display the individual country name or code.

    The other thing with the way the data is displayed on the /country route is that you can't use the browser's built in back functionality to go back to the last country you were viewing. The user can click the border option but it is always a good idea to use browser history in my opinion.

    I would recommend looking in to NextJS if you haven't already, it's really straightforward and if you can use React then you'll learn Next in no time via their docs https://nextjs.org/docs/getting-started

    Marked as helpful
    0
  • Joe Cox•80
    @joejcoxPosted almost 3 years ago

    Nice looks good. One thing on my larger screen the image is a bit squashed. One thing I'd recommend looking in to is the object-fit and object-position property on img elements, it helps a lot in this sort of situation.

    Marked as helpful
    0