Jeff McLean
@jmmarketingAll comments
- @SaeneArmaanSubmitted 16 days ago@jmmarketingPosted 15 days ago
This came out really well. I was looking at trying a css property and animating that way (I ditched it), but your requestAnimationFrame approach is great! Awesome find on that one.
I also love how you added the reset button element. Subtle, but definitely adds to the user experience. 👍🏽👍🏽
0 - @Abhirocks889Submitted 11 months ago
As it is a beginner friendly project, there weren't too many challenges.
I would like to get some feedback on the following:
Adherence of my solution to Semantic HTML. Adherence to the BEM (Block element modifier) standard. Any other general advice to improve upon.
Regards, Abhishek
@jmmarketingPosted about 2 months agoYour BEM convention looks great. You have top level block ('qr-container) and then the specific elements nested within (__title, __subtitle, etc..).
The only bit of feedback I have more specific naming of the top level block. Qr-container can be a bit more descriptive. A container can be generalized to a number of elements. Since this is a card specific component, consider updating the naming convention to qr-card, qr-card-container, or qr-card.
TLDR; Your BEM naming looks great, just consider more descriptive for future/easier reference.
Marked as helpful0