Submitted 9 months ago

QR Code component using flexbox and SCSS

Abhishek Buragohain• 120

@Abhirocks889

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

As it is a beginner friendly project, there weren't too many challenges.

I would like to get some feedback on the following:

Adherence of my solution to Semantic HTML. Adherence to the BEM (Block element modifier) standard. Any other general advice to improve upon.

Regards, Abhishek

Community feedback

Jeff McLean• 50

@jmmarketing

Posted 6 days ago

Your BEM convention looks great. You have top level block ('qr-container) and then the specific elements nested within (__title, __subtitle, etc..).

The only bit of feedback I have more specific naming of the top level block. Qr-container can be a bit more descriptive. A container can be generalized to a number of elements. Since this is a card specific component, consider updating the naming convention to qr-card, qr-card-container, or qr-card.

TLDR; Your BEM naming looks great, just consider more descriptive for future/easier reference.

Marked as helpful

Abhishek Buragohain• 120

@Abhirocks889

Posted 3 days ago

@jmmarketing Thanks for your feedback. Appreciate it. Cheers!!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord