Skip to content
OverviewSolutions
2
Comments
2
Jiří Ćmiel
@jiricmiel

All comments

  • CatalinaF-S•60
    @CatalinaF-SSubmitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    I really enjoyed this challenge and remembered a lot of the things I learned in the past. I am really proud of the documentation I made in the readme.md file so that I can easily access the knowledge I gained in this challenge in the next project.

    What challenges did you encounter, and how did you overcome them?

    Challenges:

    • I am already struggling with a margin-botton of the card in desktop view. I need to figure out how to keep it from getting bigger when the card's width is wider than 1440px.
    • It was challenging to deploy the project just because I was using an extra / in the relative path of the href for the assets and images.
    What specific areas of your project would you like help with?

    How I mentioned before I want to fix the margin or padding botton when the card's width is wider than 1440px.

    Responsive blog preview card using SASS

    1
    Jiří Ćmiel•40
    @jiricmielPosted 5 months ago

    Hello Catalina, I'll repay you your kindness with giving feedback. Your solution looks really great. I would say much better than mine. I'm gonna assume you chose different font style and card width on purpose and focus only on things that you could improve to get better as a coder. You forgot about shadow around borders of the card. You can add more shadows to an element. Just divide them with comma: box-shadow: shadow1, shadow2, etc.. Your Learning tag is not centered. It is probably due to obsolete height property. You give such element height by adding padding. There's no need of making "h1" inline-block. It is block element by default and you already gave it a width which shrinks the element to sort of inline-block. Somehow you forgot about :hover for the "h2". You should check flexbox functionality. It helps with aligning everything. I think it is not good practise to use "main" as your component container. Instead make it "main>card_element". If you're already making queries you should definitely use responsive units like "rem". It makes life so much easier when it comes to responsive design :-)

    It may look as too many comments but don't be discouraged. I'm only trying to help you improve your skills. Keep coding!

    Marked as helpful
    0
  • Prasanna Venkatesh Kumar RTV•10
    @pvk13797Submitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    I'm Already Familiar With HTML, CSS and I Have Completed this Challenge using Angular and SASS. I'm Really Excited to Use SCSS to Learn More. Will Try Another CSS Framework by Next Challenge

    What challenges did you encounter, and how did you overcome them?

    NA

    What specific areas of your project would you like help with?

    NA

    QR-Code Using Angular, SCSS

    1
    Jiří Ćmiel•40
    @jiricmielPosted 6 months ago

    Hey mate, you have used different font family for this challenge. You could use the one from style-guide and make your solution even more matching.

    0