@jiricmiel
Posted
Hello Catalina, I'll repay you your kindness with giving feedback. Your solution looks really great. I would say much better than mine. I'm gonna assume you chose different font style and card width on purpose and focus only on things that you could improve to get better as a coder. You forgot about shadow around borders of the card. You can add more shadows to an element. Just divide them with comma: box-shadow: shadow1, shadow2, etc.. Your Learning tag is not centered. It is probably due to obsolete height property. You give such element height by adding padding. There's no need of making "h1" inline-block. It is block element by default and you already gave it a width which shrinks the element to sort of inline-block. Somehow you forgot about :hover for the "h2". You should check flexbox functionality. It helps with aligning everything. I think it is not good practise to use "main" as your component container. Instead make it "main>card_element". If you're already making queries you should definitely use responsive units like "rem". It makes life so much easier when it comes to responsive design :-)
It may look as too many comments but don't be discouraged. I'm only trying to help you improve your skills. Keep coding!
Marked as helpful
@CatalinaF-S
Posted
Hi @jiricmiel! Thank you very much for your feedback :) I will review every comment you leave and improve my solution. Happy coding! :)
