Skip to content
OverviewSolutions
7
Comments
7
Joseph Goodwin
@jcgoodwin86

All comments

  • Joseph Goodwin•100
    @jcgoodwin86Posted about 1 month ago

    Great job completing the project. I Tested the site on mobile it ends up with side scrolling because the cards end up breaking out of the body { width: 300px; }. A quick fix would be to move the padding: 5rem; from body and width: 100%; from each div card to the media break point.

    Marked as helpful
    0
  • Juan•160
    @JuanTwoFourSubmitted about 1 month ago
    What challenges did you encounter, and how did you overcome them?

    Challenge faced on this problem was getting the page to center on bigger screens. Thankfully I was able to do this fairly simply after doing some research. Setting my html and body tag to a height of 100%. Next was adding display: table, margin auto to my html element. And finally I set my body tag to display: table-cell and vertical-align: middle. This made it easier to see how the page centered on any screen size.

    Four card feature section

    1
    Joseph Goodwin•100
    @jcgoodwin86Posted about 1 month ago

    I did the card layout with Grid to practice using it more, but I struggled. The way you did it with Flexbox looks more simple 👍. Centering with table-cell is interesting. Did you tried it with Flexbox or Grid? If you set body: 100vh; you can center it with flexbox.

    1
  • devkhrmnturk•60
    @devkhrmnturkSubmitted about 2 months ago
    What specific areas of your project would you like help with?

    I am waiting for your comments, thank you for your valuable time.

    perfume-card

    1
    Joseph Goodwin•100
    @jcgoodwin86Posted about 2 months ago

    Nice job. I can't find anything to give feedback on besides suggesting adding a README.

    0
  • Joseph Goodwin•100
    @jcgoodwin86Posted about 2 months ago

    Overall, it matches the layout 👍. I would start looking into using semantic HTML and using the fonts that come included with the starter files.

    0
  • petemac281•220
    @petemac281Submitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    Overcame difficulties with layout fairly easily

    What challenges did you encounter, and how did you overcome them?

    n/a

    What specific areas of your project would you like help with?

    N/A

    Social Links Profile

    1
    Joseph Goodwin•100
    @jcgoodwin86Posted about 2 months ago

    Everything looks excellent. However, the text seems to be a smaller size, which makes it a bit harder for me to see.

    1
  • Joseph Goodwin•100
    @jcgoodwin86Posted about 2 months ago

    Looks great 👍. The HTML could be improved by using semantic HTML.

    0
  • Joseph Goodwin•100
    @jcgoodwin86Posted about 2 months ago

    Overall looks great. Text size and color doesn't match the design.

    0