Jon D
@jcad57All solutions
- Submitted 2 months ago
Shopping Cart React Component
- HTML
- CSS
- JS
I could not find a good way to create the page-dimming effect when the confirmation modal pops up. I ended up using a box shadow and I mean it sort of worked but it was not part of the design file.
I would love any feedback at all on the "cleanliness" of my components, logic and JSX since this was my first time attempting a react app.
- Submitted 5 months ago
BMI Calculator
- HTML
- CSS
- JS
I would love to hear a better solution to setting background images to offset their position, like the background gradient in the header and the image of the dude eating sushi in the tablet view (it shows a left offset). I used position absolute, and it works fine however fixed heights and position absolute make me feel like that goes against responsiveness best practices.
Also, I used pseudo elements for the little guiding lines on the desktop layout - is that the best way to accomplish those? I couldn't think of another way.
Lastly, the radio buttons are very "magic number-y". They were custom so I had to manually place them properly. The main issue is the custom "outline". It overflows the container so I had to add margin-left to offset the button when it becomes selected. Are there better ways to make custom radio buttons that don't require all the extra margins to keep everything aligned?
Any other general feedback on the HTML/CSS/JS would be helpful as well.
Thanks!
