Skip to content
OverviewSolutions
2
Comments
4
Juan Benavides
@jbbenavidesr

All comments

  • Dave•5,295
    @dwhensonSubmitted over 3 years ago

    OK second try with this one! I think I've fixed the modal issue now - it was off screen before and wouldn't scroll. Based on my testing it works now. As before, I've used inert to make the modals work properly, and gap quite extensively, which means this challenge only really works well on Chrome.

    The modal design doesn't match the design specifications properly. This is my fault for not pausing to review things at the start. Matching better would involved a lot of HTML restructure. I've made a list to follow on how to approach things now and I hope I won't end up in such a situation again.

    Thanks for any feedback!

    Crowdfunding - HTML, CSS and JS

    4
    Juan Benavides•90
    @jbbenavidesrPosted over 3 years ago

    It looks great now! Really like how it is working and yesterday's issue is solved.

    I would only suggest that when I open the modal through one of the options, that option appears selected.

    1
  • Dave•5,295
    @dwhensonSubmitted over 3 years ago

    OK second try with this one! I think I've fixed the modal issue now - it was off screen before and wouldn't scroll. Based on my testing it works now. As before, I've used inert to make the modals work properly, and gap quite extensively, which means this challenge only really works well on Chrome.

    The modal design doesn't match the design specifications properly. This is my fault for not pausing to review things at the start. Matching better would involved a lot of HTML restructure. I've made a list to follow on how to approach things now and I hope I won't end up in such a situation again.

    Thanks for any feedback!

    Crowdfunding - HTML, CSS and JS

    4
    Juan Benavides•90
    @jbbenavidesrPosted over 3 years ago

    Hey, about the modal I've got an issue... When I open it, it gets cut at the bottom of the screen and there's no way for me to access what's below because it is fixed. When I try to scroll, the background moves but not the modal.

    You can maybe solve this by adding scroll to the modal and removing it from the background or something like this. I think I did that once by setting the background height to just 100vh while the modal is open, but I don't remember exactly how I approached that.

    1
  • Juan Benavides•90
    @jbbenavidesrPosted almost 4 years ago

    I have a couple of comments.

    1. I feel it's too big. at least in my screen it gets really big and I need down scrolling in order to use the rock button which makes it harder and less fun to play.

    2. Is the house selection just following the order? I did like 10 rounds and it always followed the same pattern. for this game it's better to add some randomness.

    0
  • Juan Benavides•90
    @jbbenavidesrPosted almost 4 years ago

    The name of the file is not correct, it is case sensitive, then using uppercase is making the page look for a file that doesn't exist.

    1