Skip to content
OverviewSolutions
1
Comments
5
Janez Kolar
@janez33

All comments

  • Grzegorz Sterczewski•680
    @gsterczewskiSubmitted almost 4 years ago

    I'm open to all feedback and critique. I know that my scss could be more concise, and html is little too bloated, plus my approach to handle the slider controls positioning is hacky at the moment. Also,naming thing in english is a real struggle for me. I'm curious what do you guys think about the responsivness and breakpoints that I set ?. For anyone taking the time to check out my solution: thank you. Cheers.

    Responsive site made with Sass and pure JS

    2
    Janez Kolar•140
    @janez33Posted almost 4 years ago

    Hello I've looked at your solution :) I'm consider myself as a junior front-end developer and I have to say good job :) Here is one thing about responsivness - your solution doesn't look very good at 1000px viewporth width, there is too much white space at the bottom of the page. Setting media query to 1000px is not good for your solution I think and this is just my opinion. Your design doesn't look good on big screens from 1000px to 1600px. Width settings for .layout-wrapper doesn't do anything also height. Define your media queries before you start building the site (maybe look for some standard media queries you should always look) and then change positioning of the page to look good on those media queries and also device friendly. I hope I didn't say anything wrong. Keep building, every time you build something you are improving :) Regards from Slovenia

    1
  • Janez Kolar•140
    @janez33Posted about 4 years ago

    Hello I was wondering why are you using such weird numbers for media queries and why do you repeat them every time for each section, is this a better way to keep things more organized? And why so many rems units for padding and typography - did you come up with this on your own or you imported this spacing from some library or something?

    1
  • Janez Kolar•140
    @janez33Posted over 4 years ago

    Good job :) just fix 5 HTML issues :)

    0
  • Janez Kolar•140
    @janez33Posted over 4 years ago

    You were mentioned from Matt in his e-mail, so I came to see your work, nothing to say, congratulations :D You have only 1 html issue you should fix :) Regards from Slovenia.

    2
  • Janez Kolar•140
    @janez33Posted over 4 years ago

    Hello :) I think you have some errors in your solution, you should check these first and correct them and resubmit (here is the link: https://www.frontendmentor.io/solutions/huddle-landing-page-with-curves-using-flexbox-and-css-pseudo-elements-TQgC9PRbr/report)

    I think you did a great job, maybe your buttons are too small, in design files they are bigger.

    Good job! :)

    1