jamespask
@jamespaskAll comments
- @jamespaskSubmitted over 1 year ago@jamespaskPosted over 1 year ago
Pretty proud of this one, I focused on better CSS structuring and also managed to get it pretty close to the design :)
1 - @Boboniyen01Submitted over 1 year ago
All feed back is welcome thank you
@jamespaskPosted over 1 year agoGitHub Pages can run into issues with relative links. In my experience the link will break if it is for example:
/images/image-qr-code.png
, the fix to get the image working is to add a period in front to allow the right folder to be found:./images/image-qr-code.png
0 - @jamespaskSubmitted over 1 year ago
I had issues with center aligning everything on the page with this challenge. Normally I would just put
display: flex; align-items: center; justify-content: center
on the surrounding container but that seemed to cause issues with mobile when used in tandem withheight: 100vh
, I did some googling and addingmargin: auto
seemed to fix the issue.@jamespaskPosted over 1 year agoI have a question, where should the
H1
go on an element like this? There are 3 equally important titles but the Accessibility report suggests the need for anH1
0