Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HEADINGS ⚠️:
- This solution consists lack of
<h1>so it can cause severe accessibility errors due to absence of level-one headings<h1>
- Every site must want only one
h1element identifying and describing the main content of the page.
- An
h1heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- In this solution there's three
<h2>elements, like this<h2>SEDANS</h2>. But there's no<h1>, Remember<h1>provides an important navigation point for users of assistive technologies so we want to use it wisely
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-onlyclass to hide it from visual users (it will be useful for visually impaired users)
- Example:
<h1 class="sr-only">3-column preview card component</h1>
- If you have any questions or need further clarification, you can always check out
my submissionfor this challenge where i used this technique and feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
1
jamespask• 60
@jamespask
Posted
@0xAbdulKhalid So I tried sr-only but it seems that is a bootstrap class? I did some googling and found a helpful aria-invisible class: .aria-invisible { border: 0; clip: rect(0 0 0 0); height: 1px; margin: -1px; overflow: hidden; padding: 0; position: absolute; width: 1px; }
This seemed to work
0
Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
You're right @jamespask!
sr-onlyclass is a bootstrap class, but it's not only name as that in bootstrap it's on tailwind other css frameworks too.
- Then name
sr-onlyis a general term that used from screen-reader only, peoples are tend to use the keywordsr-onlyfor pointing that out.
- I'm not using bootstrap or tailwind like frameworks for my projects but still use the
sr-onlyclass as a good accessibility practice
- PS: You can name anything as you want, but as a general conviction the name
sr-onlyis easily identified by fellow developers. That's why the name is not changed on any frameworks regardless of it's type.
0
