All comments

• 

  Chinex Okuefuna•260

  @Chinex4Submitted over 1 year ago

  This helped me alot in understanding CSS grid layout

  

  Responsive landing page using CSS grid

  1

  30
  

  Jech•100

  @j3rech0Posted over 1 year ago

  Is this the final output? It looks to me that you didn't implemented responsive layout on this challenge. I don't see any @media query in the source code.

  0

  This comment has received 3 repliesShow
• 

  SayHelloToKamil•40

  @SayHelloToKamSubmitted over 1 year ago

  Did I make this responsive according to best practice? Are my naming conventions readable for the reviewer?

  

  Responsive Product Card Component

  1

  51
  

  Jech•100

  @j3rech0Posted over 1 year ago

  Here's a few noticeable:

  • Avoid using fixed value in a container especially setting the height for the class name .outside-right-container, that section will have a dynamic content I assume, height: auto I guess is okay.
  • Also dealing with width for example in the main you could have width: 100%;max-width: 400px; for better scalability.
  • Also I think mobile-first approach is still relevant. Overall good job!

  Marked as helpful

  1