Design comparison
SolutionDesign
Solution retrospective
Did I make this responsive according to best practice? Are my naming conventions readable for the reviewer?
Community feedback
- @j3rech0Posted over 1 year ago
Here's a few noticeable:
- Avoid using fixed value in a container especially setting the
height
for the class name.outside-right-container
, that section will have a dynamic content I assume,height: auto
I guess is okay. - Also dealing with
width
for example in themain
you could havewidth: 100%;max-width: 400px;
for better scalability. - Also I think mobile-first approach is still relevant. Overall good job!
Marked as helpful1 - Avoid using fixed value in a container especially setting the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord