Isaias• 70
@Isa696
Submitted
j124klo
@j124klo
All comments
- j124klo• 40
@j124klo
Posted
The project has everything needed and even more more.
It's well commented and eassy to read. It includes main, footer, h1 and even css reset. It uses variables for collors, so it is easier to make some changes to the side. The side looks good no matter of device you use and it's orientation.
There is no issues with it. 10/10, great job.
Marked as helpful
1 - Ekta Chaudhary• 10
@itsekta
Submitted
j124klo• 40@j124klo
Posted
First and most obvious, thats not the same QR code you were given, and even if it's just Rickroll I wouldn't risk by scaning it. Remember that unknown QR and links found on internet can be really dangerous. By just scanning some random QR you can give out your personal information.
That aside, about accual code (disclaimer - i'm no expert in JS nor react so i will address what I know about):
- Your page is not phone viable. As you can check in dev tools (by pressing F12), when you select phone view option, than select change orientation to vertical, your backgroud color doesn't cover the whole screan(*). Also the top of the picture gets cut off out of screan(**).
(*) It might not be enough, but I recomend setting background color as body property instead of your conteiner property, example:
body { background-color: #d5e1ef; }
(**) If you set your middle-parts' margin to auto, it should include the whole thing even in the phone mode, example:
#Main-div { background-color: white; margin: auto; <-----------(the fix) text-align: center; width: min-content; height: min-content; border-radius: 1rem; padding: 0.4rem; }
- You aren't using the correct font, though you have a lot other. Just in case, the font is called "Outfit". You can just add this:
Other than that, and small things (size of the thing, border-radius of the white thing, text color, QR being black and gray in dark mode (how? why?)), it looks good enough.
0
