Ivan Orsolic
@ivanorsolic95
All comments
- PIvan Orsolic• 240
@ivanorsolic95
Posted
Good solution.
1 - Pikitamalarose• 310
@ikitamalarose
Submitted
What are you most proud of, and what would you do differently next time?
...
What challenges did you encounter, and how did you overcome them?
Fetch the data and fill the html with JS
What specific areas of your project would you like help with?
On firefox the content is in the center but on chrome the block is up to the top. I would like to know how to solve this problem.
PIvan Orsolic• 240@ivanorsolic95
Posted
Nice solution!
0 - Stephanie0905• 210
@Stephanie0905
Submitted
PIvan Orsolic• 240@ivanorsolic95
Posted
Your solution doesnt match with the design file provided from Frontend Mentor.
Here are coule things to notice: -error message should appear right above the input field, not under the field. Try to fix this using css property translate or any other property responsible for changing the position of HTML elements. -error message should appear only on bigger screens, not on the smaller screens such as mobile phone
- when success message on smaller devices is being displayed, I noticed that gap between dismiss message button and rest of content is too big.
Marked as helpful
0 - marcobaass• 70
@marcobaass
Submitted
What are you most proud of, and what would you do differently next time?
I build it completely with Flexbox. Looking back, a combination of Flexbox and Grid might have been easier. Other than that I had a lot of fun building it.
What challenges did you encounter, and how did you overcome them?
Making it responsive. Again, combining with grid might have helped here.
What specific areas of your project would you like help with?
Happy about any feedback.
PIvan Orsolic• 240@ivanorsolic95
Posted
There are a couple issues with your solution. First of all, on a smaller screens, when you toggle and the social media icons are being displayed, I cannot see share button.
When comes to bigger screens such as desktop, you have to much space under the div with class "profile-container".
Also when I'm zomming in your component on desktop, it is not responsive, the content does not stay in it's position.
Marked as helpful
1 What are you most proud of, and what would you do differently next time?
I am not proud of this. I learned I really need to understand how to optimize my layout for reactive display more.
What challenges did you encounter, and how did you overcome them?
I wasn't able to understand many things like how to do a linear gradient for the colored photo.
What specific areas of your project would you like help with?
Layout and code optimization. I realised how bad my layout was and stopped doing the project and plan to tackle it again in the future. I did mistakes such as not using flex:1 etc. and other interactive features.
I need some advice on how to control my layout easier.
PIvan Orsolic• 240@ivanorsolic95
Posted
I like your solution.
1- Sergiy• 880
@MrSeager
Submitted
PIvan Orsolic• 240@ivanorsolic95
Posted
I like your solution, it follows the best practices when comes to HTML and CSS
1 - Oscar Hernández• 130
@oscar84-spec
Submitted
PIvan Orsolic• 240@ivanorsolic95
Posted
I like your solution with well-written code, also responsive on every screen size.
0 - Aaliyan10• 190
@Aaliyan10
Submitted
PIvan Orsolic• 240@ivanorsolic95
Posted
Your solution uses best practices when comes to Frontend Dvelopment. Nicely done!
0 - Tometoo0304• 60
@Tometoo0304
Submitted
PIvan Orsolic• 240@ivanorsolic95
Posted
I like your solution
0 - RSGames2019• 60
@RSGames2019
Submitted
PIvan Orsolic• 240@ivanorsolic95
Posted
I would suggest to remove color variables into separate CSS file, and then import this file to the main CSS file.
ul { list-style: none; }Instead of using type selector, give this<ul>a class, then use this class to style the list.Marked as helpful
0 - SDprasanth0012• 170
@SDprasanth0012
Submitted
PIvan Orsolic• 240@ivanorsolic95
Posted
There is a grammatic error in the category name of blog ("Learining"). I like the responsiveness of your solution, but I would suggest to improve the names of the HTML classes, they should be more concise. Also write your own README, it is much better when the github repo has clear, well-written README file.
0 - Ejiofor John• 400
@echocode1
Submitted
What specific areas of your project would you like help with?
all feedbacks are welcome .more of the CSS styling
PIvan Orsolic• 240@ivanorsolic95
Posted
I noticed that your README file is missing, I would suggest to delete template README file, and write your own README, so the other developers can read about your solution, visit your solution by themselves, or see what technologies did you use to make this project.
Marked as helpful
1
