Skip to content
OverviewSolutions
18
Comments
3
aayushi simzia
@iucsim

All comments

  • feszkesfene•20
    @feszkesfeneSubmitted almost 4 years ago

    Hi everyone,

    this is my first challenge, it was quite the learning experience, because it seems so easy at first, but I was struggling a lot. I did a lot of trials and errors, searching for answers on stack overflow, etc. haha

    I couldn't get the background work completely. It looks good on desktop version, but when the screen size gets smaller the two images disappear from the screen. I tried them as img elements with fixed position, but I decided to stick with background-image as both of them generated the same result and problem that I explained. Absolute position didn't work at all, the bottom image made the window scroll, and overflow hidden didn't help. Also I didn't find any reason to include media queries as this project is small and the card can also fit in the screen well, because I used CSS Grid and Flexbox. Anyway I included one media query to reduce the font-size to have more margin around the card in the mobile version. I used Sass. Maybe later when I have more experience or find out how to fix the background image problem then I will redo this project! Thank you so much for providing such a great content and challenges for us beginners!

    I'm so excited!

    Profile card component

    1
    aayushi simzia•355
    @iucsimPosted almost 4 years ago

    Hello feszkesfene,

    Congratulations for completing first Frontend mentor challenge. Brilliant work on this challenge!

    As a background-image part is quite tricky for this challenge I'm suggesting you to use relative units vh vw and % for background-position property.

    Hope this will help you out.

    Have a nice day :)

    0
  • aayushi simzia•355
    @iucsimPosted over 4 years ago

    Hey Alex you have done great job.

    You need some improvement in html file...

    -Like in class="header-text" you have write all content in one paragraph but there are two different paragraphs in bottom -In class="right-text" rather than using <p> tag use unordered list items i.e, <ul> <li> tag.

    Hope this is gonna be useful for you as I am also newbie:)

    0
  • aayushi simzia•355
    @iucsimPosted over 4 years ago

    Hey Tymoshenko, you've done a great job here, well done!

    In .intro class I would like to suggest you to give width in pixels rather than in %..

    0