Skip to content
OverviewSolutions
42
Comments
4
Alessandra Oliveira
@itsale-o

All comments

  • Alessandra Oliveira•710
    @itsale-oPosted about 1 year ago

    Congratulations on completing the challenge!

    About your issue: you can put a <div> between the first and the second sections. Something like this:

    <div id="section1">
    your code here
</div>
<div id="bg-div"></div>
<div id="section2>
    your code here
</div>

    and then, on your CSS file you ajust the bg-div by putting the background-image and giving the div a height that fits the whole background image.

    Marked as helpful
    0
  • Alessandra Oliveira•710
    @itsale-oPosted about 1 year ago

    Congratulations on completing the challenge! Nice work.

    About your issues: if you put the qr code image inside a div is easier to centralize

    You could do something like this:

    • On the HTML
    <div class=qr-code>
     <img src="qr-code">
</div>
    • On the CSS
    .qr-code{
	display: flex;
	align-items: center;
	justify-content: center;
}

    If you want, you can even put the texts on another div, and centralize it as well. It's easier to work with single divs, one at a time (talking from my personal experience)

    Marked as helpful
    0
  • SeanBailey15•10
    @SeanBailey15Submitted about 1 year ago

    Student here, looking for feedback on my CSS in particular.

    • Ways to make the CSS cleaner
    • Is there any redundant/useless code
    • Other general tips or critiques

    A Beginner Student's Attempt

    2
    Alessandra Oliveira•710
    @itsale-oPosted about 1 year ago

    Congratulations on completing this challenge!

    I'm not a master coder myself, but for me your code is pretty clean, and the solution looks very nice.

    The minimum change I'd make is to put the font-family on the body, then you don't need to say what's the font everytime, since it doesn't change. Of course is not necessary, it's just something I prefer to do

    Marked as helpful
    0
  • Faruque Dewan•360
    @faruquedewanSubmitted over 1 year ago

    I have two questions:

    1. Is it a good practice to use different CSS files for different screen widths? If not then how to design mobile CSS after designing Desktop CSS? (Some things are overridden.)
    2. How to get the Icons in center? (They are popping up a bit.)

    Results Summary Component | Mobile First | Flexbox

    4
    Alessandra Oliveira•710
    @itsale-oPosted over 1 year ago

    About the first question: I use one CSS file for both. I did

    • @media(max-width: 1400px) {here I did the desktop deseign} and then
    • @media(max-width: 700px){here I did the mobile design}

    This usually works.

    About the icons: if I get the question right, if you use align-items: center, it may solve the problem

    0