The only thing I couldn't fix was a brief appearance of the mobile menu when I was changing the size from table to mobile.
ifaronti
@ifarontiAll comments
- @cmcrawford2Submitted 12 months ago@ifarontiPosted 12 months ago
I think your solution is excellent!! The mobile menu issue doesn't appear when I used my phone to visit the page. I don't It's a bug to be fixed. You are only seeing it because you are resizing same device width. I saw it while resizing on my PC but not my phone. Your solution is Amazing! Keep it up!
On the other hand, I think it has to do with transition in case you are worried about it. Same thing worried me for a while durring this challenge.
Great work!
Marked as helpful0 - @MelvinAguilarSubmitted about 1 year ago
Hi there π, Iβm Melvin, and this is my solution for this challenge. π
π Features:
- Progressive Web App (PWA) support. π±π
- Achieved 100% in Lighthouse score for performance, accessibility, best practices, and SEO. π
- Utilized TailwindCSS for responsive styling. π¨
- Codebase is well-maintained and formatted using Prettier. π»
- Resemblance with the original design. π¨
π οΈ Built With:
- TailwindCSS. π¨
- npm - Prettier. π»
Any suggestions on how I can enhance this solution or achieve even better performance are welcome!
Thank you. πβοΈ
@ifarontiPosted 12 months agoI've gone through most of your projects and I'm amazed at your skills expecially with CSS. I find myself going through your CSS to learn a lot of tricks. One of your comments led me to pixel-perfect which has greatly peaked my interest in improving my CSS. Thanks!! Thanks!! Thanks!!
1 - @ViktorChsSubmitted about 1 year ago
This is the first page I do with react was a good challenge but there are things that I do not know if it is quite right as would be to use a function with a state to measure the width of the screen to switch between one image or another among other doubts
@ifarontiPosted about 1 year agoIf you are talking about the background-Images or <img/> :
in CSS, use background-image: url(location of image) then in your media query (e.g @media only screen and (max-width: 375px){}), change the image location.
If you are using inline CSS or using <img/>, declare a variable in state(e.g large) whose value depends on screen size so when you are choosing the location of the image, use ternary like this: (directory/{large > 500 ? 'largeImage.jpg' : 'small.jpg'}) or <img src={directory/{large > 500 ? 'large.jpg' : 'small.jpg'}} alt=''" /> That will automatically tell the browser which image to choose depending on screen size.
Also, use useEffect to make it responsive
React.useEffect(()=>{ setLarge(window.innerwidth) }, [window.innerWidth])
Marked as helpful0 - @FrancoVaccSubmitted about 1 year ago@ifarontiPosted about 1 year ago
Hey!! Nice project.. great layout.
A suggestion, when you click border countries, the currency doesnβt change it stays same as that of the first country clicked from home page.
Nice work..
0 - @SzideloSubmitted over 1 year ago
Calculating age where the day of birth value is higher than the current day value.
I was struggling to get a valid age when the day of birth was bigger than the current day value. Ex: if current day is 27 and the day of birth was 28 I was getting -1 days as result, if 29 result -2, if 30 result -3 etc. How did you managed this issue if you had it? The way I resolved it is to get the last day from the previous month and to subtract the day value that initially resulted.
if (ageInDays < 0) { // Adjusting the age in months and days when the birthdate's day is greater than the current date's day ageInMonths -= 1; const lastMonthDate = new Date( currentDate.getFullYear(), currentDate.getMonth(), 0 ); // This gets the last day from the previous month by adding 0 as para for day ageInDays += lastMonthDate.getDate();
@ifarontiPosted over 1 year agoI just subtracted 1 month from the month input and then add: 30 days to day input if month input is April, June, September, November, 28 days if month February, 29 if day and month is 29 and February respectively, 31 if any other month. Your solution is really good too.
Marked as helpful0