Skip to content
OverviewSolutions
7
Comments
7
hannerr
@hannerr

All comments

  • Matt Cope•350
    @MatthewPCopeSubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud of getting it all done and nice clean javascript.

    What challenges did you encounter, and how did you overcome them?

    A couple styling things and getting the javascript functioning.

    What specific areas of your project would you like help with?

    Always open to feedback.

    Interactive Rating Component Solution

    1
    hannerr•100
    @hannerrPosted about 2 months ago

    Really nice work!

    0
  • hannerr•100
    @hannerrPosted about 2 months ago

    Hi, Nice job! Some small things you might want to add:

    • the company logo is a bit small compared to the design
    • on mobile there is no margin above the logo
    • on mobile the lower corners of the white box are not rounded
    • until all inputs are filled the result shows NAN - maybe 0.00 would be better?
    • I think the font in the buttons should be bold all the time, not on hover
    • i know writing readmes is annoying but it helps finding your way around a repo, if your memories are not fresh sometimes
    • nice js, but maybe you want to try to keep the calculate function smaller by making an extra function for the eventlisteners. this could get quite messy when it grows... I hope I helped a bit! cheers hanna
    0
  • hannerr•100
    @hannerrPosted 2 months ago

    Hi, Nice solution! Maybe you would like to rework some things: -> the breakpoints - maybe switch to mobile earlier ? (from 815 to 500px you get a not so nice view) -> you are still missing the possibility to switch between daily, weekly and monthly view -> the data is still hard coded or did I miss something? (it should come from data.json?)

    1
  • hannerr•100
    @hannerrPosted 3 months ago

    Hi, First of all, nice job! There are some minor issues with the design, you might want to fix. -> the vertical alignment is not center in desktop version, it´s a bit tricky with grid, I know - if you give the section:
    {display: grid; place-items: center; height: 100vh;} it is centered. -> the input field needs to change the border & text color too if input is invalid -> the sizing is a bit off (width in desktop & the margin right) There is 100 ways to do this, I´m still working on getting this right. I hope this helps!

    0
  • hannerr•100
    @hannerrPosted 3 months ago

    Hi, First of all, nice job! There are some minor issues with the design, you might want to fix. -> the vertical alignment is not center in desktop version, it´s a bit tricky with grid, I know - if you give the section:
    display: grid; place-items: center; height: 100vh; -> the input field needs to change the border & text color too if input is invalid -> the sizing is a bit off (width in desktop & the margin right)

    0
  • Akash Mishra•160
    @akashmishrahahaSubmitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    The flexbox part, next time I will try to include grid

    What challenges did you encounter, and how did you overcome them?

    Challenge was to add responsiveness

    What specific areas of your project would you like help with?

    Adding responsiveness

    Responsive product-card

    1
    hannerr•100
    @hannerrPosted 6 months ago

    Looks like a clean version!

    0
  • yoyov51234•240
    @yoyov51234Submitted 6 months ago
    What are you most proud of, and what would you do differently next time?
    1. I kept on working on the project.
    2. solved 5 issues. (1) to make 2 landing pages for mobile and desktop (2) made the tooltip from scratch (3) for the drawer picture in desktop version , i used object-position: top 0 left 0 to match the design (4) put the banner to different position on different screens (5) event bubbling : prevent it from using event.stopPropagation()
    What challenges did you encounter, and how did you overcome them?
    1. googled for the event bubbling.
    2. googled for tooltip
    What specific areas of your project would you like help with?

    Any suggestion is welcome~~ thanks `

    Article preview component

    1
    hannerr•100
    @hannerrPosted 6 months ago

    Nice one for all solution!

    0