Veera Bramha Chary• 130
@Veerabramhachary
Submitted
What specific areas of your project would you like help with?
any advice i will gladly accept
hannerr
@hannerr
All comments
- hannerr• 70
@hannerr
Posted
Hi, Nice solution! Maybe you would like to rework some things: -> the breakpoints - maybe switch to mobile earlier ? (from 815 to 500px you get a not so nice view) -> you are still missing the possibility to switch between daily, weekly and monthly view -> the data is still hard coded or did I miss something? (it should come from data.json?)
1 - Joel Guzman• 250
@jolman009
Submitted
hannerr• 70@hannerr
Posted
Hi, First of all, nice job! There are some minor issues with the design, you might want to fix. -> the vertical alignment is not center in desktop version, it´s a bit tricky with grid, I know - if you give the section: {display: grid; place-items: center; height: 100vh;} it is centered. -> the input field needs to change the border & text color too if input is invalid -> the sizing is a bit off (width in desktop & the margin right) There is 100 ways to do this, I´m still working on getting this right. I hope this helps!
0 - Joel Guzman• 250
@jolman009
Submitted
hannerr• 70@hannerr
Posted
Hi, First of all, nice job! There are some minor issues with the design, you might want to fix. -> the vertical alignment is not center in desktop version, it´s a bit tricky with grid, I know - if you give the section: display: grid; place-items: center; height: 100vh; -> the input field needs to change the border & text color too if input is invalid -> the sizing is a bit off (width in desktop & the margin right)
0 - Akash Mishra• 160
@akashmishrahaha
Submitted
What are you most proud of, and what would you do differently next time?
The flexbox part, next time I will try to include grid
What challenges did you encounter, and how did you overcome them?
Challenge was to add responsiveness
What specific areas of your project would you like help with?
Adding responsiveness
hannerr• 70@hannerr
Posted
Looks like a clean version!
0 - Pyoyov51234• 240
@yoyov51234
Submitted
What are you most proud of, and what would you do differently next time?
- I kept on working on the project.
- solved 5 issues. (1) to make 2 landing pages for mobile and desktop (2) made the tooltip from scratch (3) for the drawer picture in desktop version , i used object-position: top 0 left 0 to match the design (4) put the banner to different position on different screens (5) event bubbling : prevent it from using event.stopPropagation()
What challenges did you encounter, and how did you overcome them?
- googled for the event bubbling.
- googled for tooltip
What specific areas of your project would you like help with?
Any suggestion is welcome~~ thanks `
hannerr• 70@hannerr
Posted
Nice one for all solution!
0
