Hana Chong
@hana-chongAll comments
- @sukaloafSubmitted over 1 year ago@hana-chongPosted over 1 year ago
Hey Seth! The proportions within the container are looking great. The laptop view however isn't working very well- it's too large and the top portion isn't visible. I think this could be fixed pretty easily though by adding some additional size formatting to '.card'. It fits much better on mobile view and would look even cleaner with some side margins added. The QR image is centered perfectly on the top and sides of the card on all screen views- great job!!!
Marked as helpful1 - @mohammed-sarhad-ahmedSubmitted over 1 year ago
Greetings, everyone! I'm excited to share my solution for the NFT-component challenge. It took me approximately three hours to complete. I incorporated a significant number of utility-first classes, similar to Tailwind CSS, which greatly enhanced the code's cleanliness and scalability.
One of the more challenging aspects was determining the active state, as this was my initial encounter with the background property. Consequently, it required the three-hour time frame to ensure accuracy. However, I consider this experience a valuable learning opportunity, and I'm open to revisiting this project in the future to further refine the code.
@hana-chongPosted over 1 year agoHi Mohammad! Your solution looks great. I would just suggest increasing the border-radius on the edges of the container and image. It also seems like there's supposed to be a shadow behind the main container in the goal design. These should be straightforward fixes, and other than that your code is very readable and organized! I like how you've labeled the different sections in your CSS. Good job!!!
Marked as helpful0 - @ribeiroLeviSubmitted over 1 year ago
This was the first time i really tried to make a responsive website :) any tips are very welcome
@hana-chongPosted over 1 year agoHi Levi! Your solution looks great, and very accurate to the design! My only tip would be to add a shadow under the main white container. Other than that it's functional, clean, and the error responses work very well. Good job!
0 - @Mohamed-JameerSubmitted over 1 year ago
Feedbacks are welcomed.
@hana-chongPosted over 1 year agoHi Mohamed! I think your container and its proportions look good, but the image for each car in the top left corners isn't appearing- it looks like you correctly referenced them in your HTML, they just need to be styled in your CSS. You should also work on aligning the container vertically so it's all visible, and import the fonts that were mentioned in the style guide. You're getting there!
Marked as helpful1