Skip to content
OverviewSolutions
21
Comments
10
gomezlucas
@gomezlucas

All comments

  • gomezlucas•1,115
    @gomezlucasPosted over 4 years ago

    Looks perfect!! I am going to check those animation that u added cause I really like them. Why did you decide to use Css animations instead of React ones? I would like to know your point of you

    0
  • gomezlucas•1,115
    @gomezlucasPosted over 4 years ago

    Hey Hanna, good Job!!! i love the way you use the animations, they totally fits the challenge!

    0
  • Dor Sarel•80
    @DorSarelSubmitted over 4 years ago

    Please review my code (HTML + CSS). I`d like to get better in structuring the css & naming conventions

    Four card feature section

    2
    gomezlucas•1,115
    @gomezlucasPosted over 4 years ago

    Good job Dor! I read both your code and CSS and i found them very understandable. You are using BEM convention for the styles, which help when another developer wants to read your code. I like the way you solve the challenge with Flex. I used grid when i did it. But yours works even better.

    1
  • gomezlucas•1,115
    @gomezlucasPosted over 4 years ago

    Nice work Mata! there is just one issue with the colour border of the left card.

    0
  • gomezlucas•1,115
    @gomezlucasPosted over 4 years ago

    Hey Onasanya! Nice work! There are some issues with the logic of the filters though. For example, when you choose a Region and then type a country, the country is shown even though it is not part of that continent. You could set the default or remove the value of those filters when another one is used. Or join them and show just one result, which is achievable using React Js. Also there is a bug when you click "filter by region".

    It's a good practice to play with the logic of this kind of challenges. When I did it It help me to understand States and life Cycles. Let me know if u have any doubt or what i said doesnt make sense :)

    1
  • gomezlucas•1,115
    @gomezlucasPosted over 4 years ago

    It looks really good! there are some spacing issues in the footer, you can add margin or padding and make it looks even closer to the original . Also the color of the font, it's not the one they give us in the design. But overall nice work.

    Ps: try to write in english. I understand you because I speak spanish, but most of the people here don't speak a Latin language

    1
  • gomezlucas•1,115
    @gomezlucasPosted over 4 years ago

    Nice Work! Congrats! I d use classes to target the style of the elements. And leave Id's when I need to target elements from Js for example. It's not a rule write on stone though and it doesn't make a big difference in small projects, but it's good to take the habit. Check this link that explain the reasons why better: https://dev.to/clairecodes/reasons-not-to-use-ids-in-css-4ni4

    1
  • gomezlucas•1,115
    @gomezlucasPosted over 4 years ago

    Your code looks very clean and readable. I like that. I think it's better to use rem instead of px as a unit. It's an article that help me to understand why. https://medium.com/code-better/css-units-for-font-size-px-em-rem-79f7e592bb97

    Basically it makes better the user experience and fewer headaches when you design the responsive layout

    1
  • gomezlucas•1,115
    @gomezlucasPosted over 4 years ago

    Hey Amir! When you are uploading the solution paste the address of the github page in the live version input , so we can see it

    0