@gladstone28
@vickschap
Submitted
Hi community! I made this project a little bit differently with each bar highligting and exp. showing for each day. on hover. Also, I don't know if I had to import data from the provided JSON file only. If yes, I want to know how to do that. I simply copied the data and pasted in the Javascript file.
@gladstone28
Posted
I like your solution to this challenge. Your HTML and CSS code looks mostly fine, but there are a few minor issues and improvements you can make: In your README.md the screen should be the one shown in the challenge not the codes that you placed there. In you HTML the script tag should be above the closing body tag not below it. I raised at pull request at your Github page with this correction. If you merge the branch in the pull request this will be corrected.
Marked as helpful
@Sefat-Khan
Submitted
Rate my code. I'm new here and i'm learning web development. Plz let me know what should i have to improve.
@gladstone28
Posted
Your submission on the Results Summary Component Challenge is very good but I noticed the following which you could look at: CSS:
In your CSS, you've defined a font-family as 'HankenGrotesk', but you are not using this font-family anywhere in your styles. You can apply it to specific elements by using the font-family property.
In the CSS for your icons, you are using the .h3 class selector, which should be .icon h3 to target the h3 elements inside the .icon divs.
In your media query (@media (max-width:600px)), you've made some font and container size adjustments, which is good for responsive design. However, you can also consider making the button width 100% to ensure it fits within the container at smaller screen sizes:
Marked as helpful
@EddieVillegas
Submitted
@gladstone28
Posted
I like your Result Summary Component and learnt from it. Note however that I saw the following errors that can be easily corrected: The href attribute in the second <a> tag inside the .attribution div should point to your own website or profile, but it's currently empty. You should replace href="#" with the actual URL.
In your HTML, you've used a comment inside a meta tag. Comments are not allowed inside HTML tags. You can move this comment outside the meta tag.
@PriyankaRC16
Submitted
Hi everyone!
I have iterated and worked on my second version of the qr component page.
Any feedback will be appreciated!
Thanks
@gladstone28
Posted
I like your solution to the QR Code component challenge. However I notice the following error: In the HTML, you are missing the closing </div> tag for the <div class="body-card"> element.
Marked as helpful
@KatrineNPedersen
Submitted
Is there a way to condense the JavaScript functions more than they currently are?
@gladstone28
Posted
I like your solution to this challenge
@Dougl4z
Submitted
@gladstone28
Posted
I like your work very much. Please note however that you have a spelling error in " Mentor and tade your coding skills to " it should be "Mentor and take your coding skills to"
@vsamopyt
Submitted
I really have a problem with the background for this task. For desktop version 1440 it looks good, but for lower resolution and mobile versions, it is a full mess. I use background-color for body, and two circles as background elements and set them with position: absolute in the left top comer and the rights bottom corner. but this works badly. I need help with this.
@gladstone28
Posted
@vsamopy I like your profile card component, you gave it very good effort. Maybe you could also write a READM.md file. I learnt a lot by using the README-template.md that comes with the challenge. I am looking forward to seeing you write and include one in your project.
Marked as helpful
@gladstone28
Submitted
@gladstone28
Posted
Thank you very much. I will follow you advise in my next challenge and/or incorporate same in the next version of this challenge.
@RonyAndersson
Submitted
.
@gladstone28
Posted
I did not see a README.md in your code at Github. I learned a lot by doing a README.md and therefore suggest that you can use the template that came with the challenge to create one
@Kincyrus12
Submitted
What did you find difficult while building the project? Which areas of your code are you unsure of? Do you have any questions about best practices? Any feedback is appreciated, thank you.
@gladstone28
Posted
I got a 404 page when I clicked to view your code. Can you double check please?
@nlankwei5
Submitted
@gladstone28
Posted
I like your project but I am thinking that If you use the README-template.md file from the challenge to complete your README.md file then you will be able to give more information to the user. I helped me greatly, so I decided to tell you about it. Please let me know if I can be of any more assistance.
@srj815
Submitted
@gladstone28
Posted
There is a lot to learn from writing and submitting a README.md in your files You can use the template provided in the package.
