Results summary component-flexbox, grid, custom properties

Community feedback

• 

  P

  gladstone28•530

  @gladstone28Posted over 1 year ago

  Thank you very much. I will follow you advise in my next challenge and/or incorporate same in the next version of this challenge.

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further.You can wrap up .attribution class within <footer> as a part of semantics.

  Wrapping the .attribution class within a <footer> element is a great way to improve the semantics and structure of your code. By using the appropriate HTML elements for their intended purpose, you enhance the accessibility and readability of your website.

  Here's an example of how you can wrap the .attribution class within a <footer> element:

  <footer>
  <div class="attribution">
  Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. 
  Coded by <a href="#">Gladstone Rose</a>.
  </div>
  </footer>
  

  By enclosing the attribution content within the <footer> element, you clearly indicate that it is a part of the footer section of your webpage. This is beneficial for assistive technologies and search engines, as they can better understand the structure and hierarchy of your content.

  0