@thedanielkingSubmitted 23 days ago
P
Fatih ŞAHİNBAŞ
@fsahinbasAll comments
- @kaoutar-ouadihSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of completing this challenge!
What challenges did you encounter, and how did you overcome them?.
What specific areas of your project would you like help with?Anything that can help me improve.
P@fsahinbasPosted 6 months agoİt is perfect job. There is only a few css mistakes. But, totaly i liked it.
0 - @Abed001Submitted 6 months agoWhat are you most proud of, and what would you do differently next time?
i am now know how to deal with context api
- P@danmlarsenSubmitted 6 months ago
- @kaoutar-ouadihSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of completing this challenge!
What challenges did you encounter, and how did you overcome them?I struggled with absolute positions and how to addjust them for responise design.
What specific areas of your project would you like help with?Anything that can help me improve.
- @Si1entERASubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
The completion of the project.
What challenges did you encounter, and how did you overcome them?The layout for the desktop view but besides that I'm somewhat satisfied with the results.
P@fsahinbasPosted 7 months agoI think there are some failures about responsive views.
0 - @Ridwan10000Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
Used SCSS for the first time
What specific areas of your project would you like help with?I had hard time to style the project. I need seek help in different techniques to approach a style. Also It's difficult for me to write the optimal code. Please Help.
P@fsahinbasPosted 7 months agoIt is good work but there are some missing points. It think these are because of not reading readme files and not check previews carefully.
0 - @QrisnoSubmitted 7 months agoWhat challenges did you encounter, and how did you overcome them?
Creating hovered state of the image was a bit challenging till I remembered how to solve that.
What specific areas of your project would you like help with?I would like to receive code improvement suggestions, maybe I missed architecture and file structure concerns.
P@fsahinbasPosted 7 months agoIt is good work. You apply BEM well. I think you forgot the avatar at the footer
0 - P@AntonvasilacheSubmitted 9 months agoWhat are you most proud of, and what would you do differently next time?
- Managed to implement the game vs CPU functionality. Would probably probably try to rely less on useEffect if I had to do it again
- Adding the outline on hover for the active player, and then turning it to full color was a nice challenge - I did by using the player turn state to dynamically display the outlines, then disabling the container and filling the image on click.
...- Creating the play vs CPU functionality was the most challenging aspect here - I had to create a function that adds a CPU move based on the remaining tiles, and then call that function after every human player move. This worked well when the human players started the game, but not so much if wanted to the CPU to start. I managed to make it work only by writing a very long if condition in a useEffect hook.
What specific areas of your project would you like help with?useEffect(() => { if ( (gameType === "CPU" && !winner && playerTurn === player2Mark && player2Mark === "O" && !initialCpuMove && moveNumber > 0) || (gameType === "CPU" && !winner && playerTurn === player2Mark && player2Mark === "X" && initialCpuMove && moveNumber > 0) ) setTimeout(() => { addCpuMove(gameboard); }, 0); }, [playerTurn, winner, gameType, player2Mark, gameboard, initialCpuMove]);Probably a way to make the CPU player somewhat smart, instead of relying on random moves.
- P@Towbee05Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of the site I built, it is working well, not 100% perfect though.
What challenges did you encounter, and how did you overcome them?Getting to arrange each element proved tougher than it was meant to be. Taking a break to think about how to get through with this really helped me
P@fsahinbasPosted 7 months agoHi Tobi, without a few design faults it is excellent job.
0 - P@Towbee05Submitted 8 months ago
- @jnsorianoSubmitted over 1 year agoP@fsahinbasPosted 7 months ago
Very good work. But there are some small missings. I think you should not read guide about style and readme files.
0 - @MrSeagerSubmitted 8 months agoWhat challenges did you encounter, and how did you overcome them?
When using Bootstrap it was difficult to change checkbox and yeah I did
- @dynamic109Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?,
What specific areas of your project would you like help with?.
- @MateuszZalewSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
Next time I need to think more about organizing my css files, I had css classes that were used in more than one component.
P@fsahinbasPosted 8 months agoExcellent! Just I have a refactoring offer that without selection of rate, we should not send form.
Marked as helpful0 - P@35degreesSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of working through lots of JS challenges and slowdowns. I had to use a lot of external resources and found experts I wouldn't have found otherwise. I get stuck with trying to have multiple JS threads going and I figured out how to have one, but it might be a long thread that repeats a couple of times.
What challenges did you encounter, and how did you overcome them?I got stuck for a long time on working with both the data from the json file and the input from the user coming together. I got frustrated with local variables and not being out to scope them globally but I worked out a creative solution where I tie the correct answer to the button itself, I was excited when I figured out how to do it.
What specific areas of your project would you like help with?My JS code can be wordy and this one possible repeats. I re-fetch the data list everytime an answer is clicked by the user and that seems like it wouldn't be efficient for future large projects I work on (but it works fine here with a smaller data file).
- @gmagnenatSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
This challenge has stretch my experience with vanilla JavaScript. I did some refactoring to try and optimise my solution with better readability and code organisation.
The next time I want to first list all the interactions, expected actions and expected results before starting to write a line of code. It will probably help to have a better structure from the start.
What challenges did you encounter, and how did you overcome them?By working on this challenge there was always a lot of questions popping in my head. How do I generate a random string, how to I modify the string to include more characters, how to I calculate the strength of the password?
By doing researches, reading posts, MDN documentation, I usually find the answers to get started and it triggers new questions. It's a constant loop but at least there is a starting point.
What specific areas of your project would you like help with?I added (to try) a debounce function to reduce the function call and dom update. Is there better ways to do this?
I'm open to any suggestions on code organisation in vanilla JavaScript.
P@fsahinbasPosted 8 months agoHi Gwenaël, I really like your app. Well prepared project.
1 - P@MatthewPCopeSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of making the javascript nicely organized and easy to read. I also started incorporating more comments which makes it easier for me to go back and remember what's going on.
What challenges did you encounter, and how did you overcome them?The javascript is always a little daunting to start but once you get going and really focus on what needs to be happening it starts getting easier.
What specific areas of your project would you like help with?My media queries aren't perfect, mid sized screens look a little off but other than that.
